Feature: suggest command usage for misspelt commands#760
Conversation
F4zii
requested review from
manusaurio and
sco1
and removed request for
a team
MarkKoz
added
a: backend
There was a problem hiding this comment.
The tags cog is not the right place for this since this feature is not actually related to tags. As it is, it will suggest commands when tags are fetched. This may make sense when this is triggered via the CommandNotFound error but it doesn't when using the !tags get command or any of its aliases.
You're piggybacking off the tags being fetched by the error handler when a command isn't found. Instead, the error handler should call this code more directly. It may be better to wait for #757 since that cleans up the error handler quite a bit.
Furthermore, is this handling subcommands properly? Is fuzzywuzzy good enough for this application? After all, the tags had better results with a custom algorithm.
MarkKoz
added
the
s: waiting for author
|
Hey mark, as I've said, the current structure of the error_handler is a bit hard to change for that usage (since it reinvokes every misspelt command as a tag), I can wait or change its implementation if needed |
Migration to error_handler.py Suggesting misspelt commands, in progress
…github.com/python-discord/bot into feat/F4zi/CommandSuggestion
Since its used to get the input of the command, its not needed again In the function (callback) call
preventing message spam by the bot when commands are misspelt
When found a similar command, the bot sent a suggestion about the full command name This was fixed by saving the matching alias and sending it instead of sending the full command name
|
Hello, the feature is ready. Note: Few suggestions could result in a spam |
The returned value was changed from True to False If we didn't return True (sent the tag) throughout the code It means we didn't send anything, we should return False
get_command was changed to - display_tag, the name didn't fit, since its not the command itself. command_on_cooldown was taken out of display_tag to get the option to reuse it in another scope Docstrings modified
F4zii
requested review from
Den4200,
SebastiaanZ,
jb3,
ks129 and
mbaruh
as code owners
|
I screwed up, I am sorry. Attempting to fix. |
Xithrius
force-pushed
the
feat/F4zi/CommandSuggestion
branch
from
e46693a to
9a00d70
Compare
Since the cogs folder has been removed, the error_handler and tag cogs had to be removed and transfer into their respective places in the exts folder.
|
Works with long commands and their arguments. Works with the smallest commands as well. So far I haven't found any bugs with this command and the way that it's implemented. Still deciding if this should exist within mod channels at all, since it may just be noise at that point to the mods. At the same time, the error stays up for 10 seconds, so instead of having to retype/edit the command, it can be copy/pasted. |
|
A user with no roles executing a moderator+ only command along with a regular command (typed incorrectly) that anyone can execute. |
|
This is the outcome of a recent poll. I think the conclusion that I can reach here is that only helpers and below should get command suggestions. |
|
Here are examples of a user at different roles executing commands incorrectly. No-role user: Helper: Moderator: Admin: |
|
|
10 participants
Feature: suggest similar command(s) to a misspelt command
Resolves #742