Sentry SDK setup#762
Merged
Merged
Conversation
Member
Author
|
|
Member
Author
|
This PR has also had to remove the API logging handler (on our plan anyway) since it was blocking sentry from making it's API calls. |
… command context.
jb3
force-pushed
the
setup-sentry-sdk
branch
2 times, most recently
from
5c35d8c to
93c069b
Compare
jb3
force-pushed
the
setup-sentry-sdk
branch
from
93c069b to
aa12d72
Compare
jb3
requested review from
SebastiaanZ and
eivl
and removed request for
a team
MarkKoz
reviewed
Feb 21, 2020
MarkKoz
reviewed
Feb 21, 2020
MarkKoz
added
a: backend
jb3
force-pushed
the
setup-sentry-sdk
branch
from
ad4f53c to
24ddab5
Compare
MarkKoz
approved these changes
Feb 21, 2020
SebastiaanZ
approved these changes
Feb 21, 2020
Contributor
SebastiaanZ
left a comment
SebastiaanZ
left a comment
There was a problem hiding this comment.
Tested, everything seems to work. I'm not familiar enough with the sentry_sdk to think deeply about the actual integration, though.
Contributor
|
Is this ready to be merged @Jos-B? Is the environment variable set in prod? |
Member
Author
|
@SebastiaanZ It's something which we can adapt as we find a workflow which suits us well. Right now just storing errors somewhere is useful and we'll find out if we need anything else as time goes on. @MarkKoz the variable is in prod 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the Sentry SDK to the bot.
This PR will also setup basic tags to link errors together.