Rename constants to match their guild counterparts#782
Merged
Conversation
MarkKoz
added
t: feature
MarkKoz
requested review from
ikuyarihS and
manusaurio
and removed request for
a team
They no longer exist in the guild. * Move devlog under the "Logs" category
It makes the code which uses it more readable. A comment was added to explain the discrepancy between the constant's name and the name in the guild.
Nothing was using it.
They used to only be loaded in "debug mode" because the main guild was used to test the bot. However, we have since moved to using a separate test guild so it's no longer a concern if these cogs get loaded. It was confusing to some contributors as to why these cogs were not being loaded since the debug mode isn't really documented anywhere.
MarkKoz
force-pushed
the
feat/backend/b496/rename-constants
branch
from
c0ac17f to
14536f8
Compare
Lists were getting too long to be readable as one line. Having each element on a separate line also reduces merge conflicts.
This name better explains what the list is for.
Delete duplicate keys that were missed in the merge
Contributor
|
I've resolved the merge conflict & added the role & channel groupings to the YAML that were only present in I still need to test the changes but I'm not currently at a machine capable of doing so. |
sco1
force-pushed
the
feat/backend/b496/rename-constants
branch
from
6867cc5 to
284c1de
Compare
|
Sentry issue: BOT-1W |
lemonsaurus
approved these changes
Feb 28, 2020
Contributor
lemonsaurus
left a comment
lemonsaurus
left a comment
There was a problem hiding this comment.
Looks excellent. This will make them much more intuitive to work with.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #496
Contributors will have an easier time configuring the constants if their names line up with the names in the guild. Not all names were changed to be exact; mostly the staff-only channels were left alone since they were already adequately descriptive.