Skip to content

Added Pagination to !roles command#807

Merged
scragly merged 8 commits into
python-discord:masterfrom
ks129:roles-command-pagination
Mar 5, 2020
Merged

Added Pagination to !roles command#807
scragly merged 8 commits into
python-discord:masterfrom
ks129:roles-command-pagination

Conversation

@ks129
Copy link
Copy Markdown
Contributor

@ks129 ks129 commented Mar 1, 2020

Also made some fixes with variable names, comments and moved Total roles from footer to title. Closes #791

@ks129 ks129 requested a review from a team as a code owner March 1, 2020 07:22
@MarkKoz MarkKoz added a: information Related to information commands: (doc, help, information, reddit, site, tags) status: needs review t: bug Something isn't working p: 2 - normal Normal Priority labels Mar 1, 2020
Comment thread bot/cogs/information.py Outdated
Copy link
Copy Markdown
Contributor

@eivl eivl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine.

Comment thread bot/cogs/information.py Outdated
@sco1 sco1 added s: waiting for author Waiting for author to address a review or respond to a comment and removed status: needs review labels Mar 4, 2020
@ks129 ks129 requested a review from sco1 March 5, 2020 07:11
@scragly scragly merged commit 5c0cef2 into python-discord:master Mar 5, 2020
@ks129 ks129 deleted the roles-command-pagination branch March 17, 2020 10:07
@Xithrius Xithrius removed the s: waiting for author Waiting for author to address a review or respond to a comment label May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: information Related to information commands: (doc, help, information, reddit, site, tags) p: 2 - normal Normal Priority t: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Truncation of !roles Command Embed

7 participants