Add one second padding to format_infraction_with_duration#819
Closed
Akarys42 wants to merge 2 commits into
Closed
Conversation
It caused the message to be rounded one second down, for example 59m and 59s instead of 1h
Akarys42
requested review from
SebastiaanZ and
scragly
and removed request for
a team
Akarys42
added
the
a: moderation
Contributor
|
This won't work if it is not just a second, sometimes it can be up to 5 seconds later, and so adding a simple second will not fix the issue. It is better to check the actual time and try to round it to round it up if the seconds is close enough to 60. |
Contributor
Author
|
Closing this PR as the fix will take more work than that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It caused the message to be rounded one second down, for example
59 minutes and 59 secondsinstead of1 hour, because of the wayhumanize_deltaworks. This PR simply add a one second padding in order to make the infraction message proper.