Subcommand search and search any to search inside tags' contents and not names.#823
Merged
MarkKoz merged 6 commits intoMar 9, 2020
Merged
Conversation
…ntents instead of names - `!tag search` will search for multiple keywords, separated by comma, and return tags that has ALL of these keywords. ` !tag search any` is the same as `!tag search` but it return tags that has ANY of the keyword instead.
ikuyarihS
added
t: feature
ikuyarihS
requested review from
MrHemlock and
jerbob
and removed request for
a team
MarkKoz
requested changes
Mar 8, 2020
- Refactored `if` block - change to only send result when there is any result. - Added better type hinting for `check` argument of `_get_tags_via_content` - changed from `callable` to `Callable[[Iterable], bool]`. Thanks to @MarkKoz 's reviews Co-Authored-By: Mark <markkoz@users.noreply.github.com>
MarkKoz
requested changes
Mar 8, 2020
…hen multiple tags are found. - Added a truthy check for each `query` since `','.split()` returns a list of two empty strings. - Changed from `Did you mean ...` to `Here are the tags containing the given keyword(s):` to be much more descriptive about the results - they are `tag` and not `term` to be searched.
lemonsaurus
requested changes
Mar 8, 2020
Contributor
lemonsaurus
left a comment
lemonsaurus
left a comment
There was a problem hiding this comment.
Mostly high quality code, but I have a few objections before I can approve.
- Show the process of sanitizing the List[str] `keywords_processed`. - Show the process of finding tag for `matching_tags` ( was `founds` ). - Refactored the logic to find boolean `is_plural`. - Minor wording changes for docstring.
lemonsaurus
approved these changes
Mar 8, 2020
Contributor
lemonsaurus
left a comment
lemonsaurus
left a comment
There was a problem hiding this comment.
With these changes, I've got no objections. Looks good, nice work!
MarkKoz
requested changes
Mar 8, 2020
Contributor
MarkKoz
left a comment
MarkKoz
left a comment
There was a problem hiding this comment.
It should be indicated somewhere in the embed that results are being truncated.
Co-Authored-By: Mark <kozlovmark@gmail.com>
Contributor
Author
|
You are right, the truncating was copied over from I've added paginator for it just like in |
- Split `_get_tags_via_content` - introduce `_send_matching_tags` - `_send_matching_tags` will send and paginate like `!tag` - Simplified `is_plural` even more.
MarkKoz
approved these changes
Mar 9, 2020
Contributor
MarkKoz
left a comment
MarkKoz
left a comment
There was a problem hiding this comment.
Using a paginator slipped my mind! Yes, that is a better solution than adding a truncation message somewhere. Creating a separate function to send the results was a good idea. I like that you changed the footer to explain how to show a tag - I think that's more useful than showing the keywords used.
MarkKoz
deleted the
tag-search-searches-tags-via-content-instead-of-names
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #804
This PR introduces two new subcommands to
!tagthat will allow searching for tags via contents instead of names:!tag searchwill search for multiple keywords, separated by comma, and return tags that has ALL of these keywords.!tag search anyis the same as!tag searchbut it return tags that has ANY of the keyword instead.Examples: