Skip to content

Log unhandled errors from event listeners #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SebastiaanZ merged 2 commits into from
May 5, 2020
Merged

Log unhandled errors from event listeners #919

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c48aa9
Log unhandled errors from event listeners
MarkKoz Apr 29, 2020
e1e26e1
Merge branch 'master' into bug/backend/911/log-listener-exceptions
SebastiaanZ May 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions bot/bot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import aiohttp
import discord
from discord.ext import commands
from sentry_sdk import push_scope

from bot import DEBUG_MODE, api, constants
from bot.async_stats import AsyncStatsClient
Expand Down Expand Up @@ -155,3 +156,14 @@ async def wait_until_guild_available(self) -> None:
gateway event before giving up and thus not populating the cache for unavailable guilds.
"""
await self._guild_available.wait()

async def on_error(self, event: str, *args, **kwargs) -> None:
"""Log errors raised in event listeners rather than printing them to stderr."""
self.stats.incr(f"errors.event.{event}")

with push_scope() as scope:
scope.set_tag("event", event)
scope.set_extra("args", args)
scope.set_extra("kwargs", kwargs)

log.exception(f"Unhandled exception in {event}.")