Update to Antimalware Filter (.txt uploads)#925
Merged
Conversation
…re longer than 2000 characters
…re longer than 2000 characters
…onger than 2000 chars
Savant-Dev
requested review from
aeros and
ikuyarihS
and removed request for
a team
lemonsaurus
approved these changes
May 4, 2020
Contributor
lemonsaurus
left a comment
lemonsaurus
left a comment
There was a problem hiding this comment.
This looks great! I really like the language in that message, especially the word zapped.
MarkKoz
added
a: filters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a debate not only on the issue page: (see #889) but also in #meta a few times, and the consensus seemed to be that the primary focus should be the .txt file extension as there was no reason to unblock .csv, .json, or like file types.
Also, as for the message to display, I wanted to cover both case scenarios (someone who uploaded code, and someone whose message was too long) and writing a longer embed was the least expensive way to do so in my opinion. Here is a attachment of the output (don't mind the hyperlink, that's obviously just my config 😄) Please let me know if any changes should be made :)
