Filtering: don't attempt to send additional embeds for invalid invites#936
Merged
Conversation
MarkKoz
added
t: bug
kwzrd
approved these changes
May 25, 2020
Contributor
kwzrd
left a comment
kwzrd
left a comment
There was a problem hiding this comment.
Good fix! Let's get this merged.
The cog looks like it could use a rewrite - but let's leave that for another day.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invalid invites won't have data available to put in the embeds, so don't send them! Moderators will still be notified the filter was triggered. However, I'm open to changing this since it was suggested invalid invites could be could be outright ignored.
Fixes #929
Fixes BOT-3Z