Source command#955
Merged
Merged
Conversation
Contributor
|
Before a proper review, And what's the reason for the two identical links in the title and the footer? |
- Renamed cog from `Source` to `BotSource` for itself (bot will be unable to get cog, because this always return command). - Moved checks status from footer to field and changed it's content.
Contributor
Author
|
@Numerlor Is this better now? I removed the link from the title and made converter raising |
MarkKoz
added
a: information
MarkKoz
requested changes
May 31, 2020
Contributor
MarkKoz
left a comment
MarkKoz
left a comment
There was a problem hiding this comment.
!source acceptdoesn't work - it triggers anInWhitelistCheckFailure. The source command should avoid triggering any checks.- Could you make aliases defined in
alias.pyresolve to their actual commands when used with!source? - Is it possible to make this work for the tag aliases? It could link to the markdown files.
MarkKoz
added
s: waiting for author
Co-authored-by: Mark <kozlovmark@gmail.com>
MarkKoz
reviewed
Jun 1, 2020
ghost
added
needs 1 review
and removed
s: waiting for author
MarkKoz
requested changes
Jun 18, 2020
ghost
added
s: waiting for author
MarkKoz
reviewed
Jun 18, 2020
| src = source_item.callback.__code__ | ||
| filename = src.co_filename | ||
| elif isinstance(source_item, str): | ||
| tags_cog = self.bot.get_cog("Tags") |
Contributor
There was a problem hiding this comment.
Technically, the cog could be unloaded between when the converter is used and this part of the code is reached. But this is an edge case that I don't think we should worry about, as it would overcomplicate the code.
ghost
added
needs 2 approvals
and removed
s: waiting for author
MarkKoz
requested changes
Jun 18, 2020
MarkKoz
reviewed
Jun 18, 2020
MarkKoz
approved these changes
Jun 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #331
Created
!sourcecommand, that supports 3 types of source items: Help command, command, cog. Send embed that has a link to GitHub, help text of the item and when command/cog, are you able to run it in this context.