Merge changes from aaaaAAAA/assets/duck-builder into branding#148
Merge changes from aaaaAAAA/assets/duck-builder into branding#148Shivansh-007 wants to merge 1 commit into
Conversation
lemonsaurus
left a comment
There was a problem hiding this comment.
A few important notes:
- There are now two silverduck templates folders in the quackstack folder. We only need one, let's keep the one with the underscore.
- Nobody is using the masks, so let's get rid of the masks folder.
I think for the sake of my sanity, we need to reorganize a little bit. This might be a breaking change for quackstack if it has already implemented and hardcoded the locations, but I think we can afford that.
@Akarys42 @vcokltfre giving you guys a heads up, since I'm suggesting a potentially breaking change here.
Let's reorganize these folders
Here's my suggestion for new organisation
quackstack/
├─ ducky/
│ ├─ accessories/
│ │ ├─ hats/
│ │ ├─ outfits/
│ │ ├─ equipment/
│ ├─ templates/
├─ duck-person/
│ ├─ accessories/
│ │ ├─ hats/
│ │ ├─ outfits/
│ │ │ ├─ variation_1/
│ │ │ ├─ variation_2/
│ │ ├─ equipment/
│ │ │ ├─ variation_1/
│ │ │ ├─ variation_2/
│ ├─ templates/
│ │ ├─ variation_1/
│ │ ├─ variation_2/
│ │ ├─ bill.png
│ │ ├─ head.png
│ │ ├─ eye.png
├─ README.md
And then of course, we'd have to rewrite the README to explain how this all works. But we can start by just.. merging the two readmes into one.
|
Sure, I will work on this pull request first, and can then implement the changes on the quackstack duck builder, if vco is fine with it. |
|
There was a discussion in #dev-branding, where it was decided that:
|
The changes include: