Skip to content

Merge changes from aaaaAAAA/assets/duck-builder into branding#148

Closed
Shivansh-007 wants to merge 1 commit into
python-discord:mainfrom
Shivansh-007:main
Closed

Merge changes from aaaaAAAA/assets/duck-builder into branding#148
Shivansh-007 wants to merge 1 commit into
python-discord:mainfrom
Shivansh-007:main

Conversation

@Shivansh-007
Copy link
Copy Markdown
Contributor

The changes include:

  • Add all the manduck assets!
  • Fix the ninja outfit for normal ducks.
  • Fix the glasses!
  • Restore partially invisible accessories from the duck builder.

Copy link
Copy Markdown
Contributor

@lemonsaurus lemonsaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few important notes:

  • There are now two silverduck templates folders in the quackstack folder. We only need one, let's keep the one with the underscore.
  • Nobody is using the masks, so let's get rid of the masks folder.

I think for the sake of my sanity, we need to reorganize a little bit. This might be a breaking change for quackstack if it has already implemented and hardcoded the locations, but I think we can afford that.

@Akarys42 @vcokltfre giving you guys a heads up, since I'm suggesting a potentially breaking change here.

Let's reorganize these folders

Here's my suggestion for new organisation

quackstack/
├─ ducky/
│  ├─ accessories/
│  │  ├─ hats/
│  │  ├─ outfits/
│  │  ├─ equipment/
│  ├─ templates/
├─ duck-person/
│  ├─ accessories/
│  │  ├─ hats/
│  │  ├─ outfits/
│  │  │  ├─ variation_1/
│  │  │  ├─ variation_2/
│  │  ├─ equipment/
│  │  │  ├─ variation_1/
│  │  │  ├─ variation_2/
│  ├─ templates/
│  │  ├─ variation_1/
│  │  ├─ variation_2/
│  │  ├─ bill.png
│  │  ├─ head.png
│  │  ├─ eye.png
├─ README.md

And then of course, we'd have to rewrite the README to explain how this all works. But we can start by just.. merging the two readmes into one.

@Shivansh-007
Copy link
Copy Markdown
Contributor Author

Sure, I will work on this pull request first, and can then implement the changes on the quackstack duck builder, if vco is fine with it.

@Shivansh-007
Copy link
Copy Markdown
Contributor Author

There was a discussion in #dev-branding, where it was decided that:

  • All quackstack assets would be moved to its repository.
  • People will have to make 2 PRs if they want to add their accessories to quackstack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants