Remove transparent margin in logo_discord.svg's#31
Merged
Conversation
lemonsaurus
approved these changes
Oct 11, 2019
lemonsaurus
added a commit
that referenced
this pull request
Apr 17, 2020
Remove transparent margin in logo_discord.svg's Former-commit-id: f581d0a
lemonsaurus
added a commit
that referenced
this pull request
Apr 17, 2020
Remove transparent margin in logo_discord.svg's Former-commit-id: 2a6a2406e91d92c842656d184264f3249c966c9b Former-commit-id: 63f80ff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logo_discord.svg and .min.svg files had a transparent margin around the logo, instead of being cropped as closely to the content as possible. This made them unsuitable for favicon generation.
I removed this extra space using Inkscape and minified the result again using https://www.svgminify.com/
All PNGs which were generated from the original SVGs had no margin, so they remain as they are.