Skip to content

Add blinking logos for guild icon#35

Merged
lemonsaurus merged 4 commits into
python-discord:masterfrom
Denayder:master
Nov 25, 2019
Merged

Add blinking logos for guild icon#35
lemonsaurus merged 4 commits into
python-discord:masterfrom
Denayder:master

Conversation

@Denayder
Copy link
Copy Markdown

Heyo! I read in #meta that you guys are looking for more animated logos, and I thought I'd give it a shot. I came up with this, and I hope it's okay :)

I can make whatever changes and tweaks requested, if the idea for the icon is accepted 😁

I hope you like it. Thank you for reading and considering this. 😁

Copy link
Copy Markdown
Contributor

@kwzrd kwzrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

For the sake of consistency with the other animations we have, could you also export one in 1024 x 1024 resolution, named blinky.gif?

kwzrd
kwzrd previously approved these changes Nov 23, 2019
@Denayder
Copy link
Copy Markdown
Author

Looks good to me!

For the sake of consistency with the other animations we have, could you also export one in 1024 x 1024 resolution, named blinky.gif?

Ah, missed that one! Thank you for the positive feedback 😁

Copy link
Copy Markdown
Contributor

@lemonsaurus lemonsaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! Can you add a 5 second pause to the end of this animation, following the conventions established by the other animated logos? For example, it can blink 6 or 8 times, and then take a 4 second break. During this break it should display the default logo. It's also important that the first frame of the gif is our regular logo (not sure if that's the case here), so that it will display correctly when not hovering.

Otherwise this is good work!

@Denayder
Copy link
Copy Markdown
Author

Denayder commented Nov 25, 2019

Looks nice! Can you add a 5 second pause to the end of this animation, following the conventions established by the other animated logos? For example, it can blink 6 or 8 times, and then take a 4 second break. During this break it should display the default logo. It's also important that the first frame of the gif is our regular logo (not sure if that's the case here), so that it will display correctly when not hovering.

Otherwise this is good work!

Hey Lemon! Thank you very much for the positive feedback. I believe I made the changes that you requested. If you have additional feedback, please feel free to let me know and I'll get right on it 😁

Side note: I'm not sure how I dismissed the review thing (https://prnt.sc/q1sa9q), but it wasn't intentional haha 😅

Copy link
Copy Markdown
Contributor

@lemonsaurus lemonsaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry about that, reviews automatically get dismissed when new changes are made. This is because the old review is then considered stale, as in, it's no longer good.

This looks better, but the pause seems to be around 3 seconds. can you make it 4 seconds? I'd be happy to approve it at that point. It looks like I wrote both 5 and 4 seconds in the previous request, sorry about that. 4 is what we want.

@Akarys42
Copy link
Copy Markdown
Contributor

Hi, also don’t forget to update the evergreen attributes so your new logo can be used! (Pretty cool logo btw)

@Denayder
Copy link
Copy Markdown
Author

Don't worry about that, reviews automatically get dismissed when new changes are made. This is because the old review is then considered stale, as in, it's no longer good.

Ahh, thank you for the explanation. That makes sense 😁

This looks better, but the pause seems to be around 3 seconds. can you make it 4 seconds? I'd be happy to approve it at that point. It looks like I wrote both 5 and 4 seconds in the previous request, sorry about that. 4 is what we want.

Phew, looks like I need to learn how to count properly haha - It now waits exactly 4 seconds before continuing to the next one. 😄

Hi, also don’t forget to update the evergreen attributes so your new logo can be used! (Pretty cool logo btw)

Ahh yeah! Thank you for the reminder! I'll get that done once this gets approved 😁

Copy link
Copy Markdown
Contributor

@lemonsaurus lemonsaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lemonsaurus lemonsaurus merged commit 7214453 into python-discord:master Nov 25, 2019
lemonsaurus added a commit that referenced this pull request Apr 17, 2020
Add blinking logos for guild icon

Former-commit-id: 7214453
lemonsaurus added a commit that referenced this pull request Apr 17, 2020
Add blinking logos for guild icon

Former-commit-id: 7214453
Former-commit-id: 3e95837
lemonsaurus added a commit that referenced this pull request Apr 17, 2020
Add blinking logos for guild icon

Former-commit-id: 266acf0774b252f315af7a05fd2b5598eb663b8d
Former-commit-id: 3e95837
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants