Adding Diwali assets#96
Conversation
|
Thank you for contributing to Python Discord! Please check out the following documents:
|
gustavwilliam
left a comment
There was a problem hiding this comment.
Thank you for this contribution! I have viewed the pngs and they look good. Do we need all of these sizes, though?
I see you've added the same files in multiple places. I think it would be nice to have the same file in only one place, so it's easier to maintain. Since I both assume we won't be modifying this later on and appreciate having them accessible in both logical places, I won't request changes on this. It's more of a general comment about having it in multiple places and mentioning that it would be nice to have the exact same file in only one place.
|
I took the reference from |
|
Well, one of the downside would be the repo size, if we don't need the different sizes, then why should we have them? We can rerender the svg at any time. Although, no need to delete them now, since they are in the history. It isn't a big deal anyway. I really like the assets, very good job! |
|
Okay. It'll probably be fine to store them in multiple places this time. @Akarys42 yes, that's exactly the reason for including only the necessary versions. If any new ones are needed, there are (hopefully) source files to generate them from. That may be something to keep in mind in the future. |
gustavwilliam
left a comment
There was a problem hiding this comment.
Great work! I like it.
|
Where did you find the assets for these icons? |
We'll need to make sure the licenses are in order before merging something into branding
|
I don't actually remember the pin point location of them |
|
Ok I found the source with reverse image search |
|
In this case, we can add attribution to the readme, in the licenses section, and link back to the original source. Add a comment that this attribution holds for the assets in the diwali folder (see how we do it for lemoji in the readme) and mention that the work is derivative (as opposed to using the asset as-is). |
|
i think with this |
lemonsaurus
left a comment
There was a problem hiding this comment.
Gorgeous assets. Attribution looks adequate. Let's merge.
No description provided.