Update form.py

[IlluminatiFish]

A regex check to validate webhook urls instead of a substring check

[HassanAbouelela]

Hi,

Please follow the proper contribution guidelines before making a PR to open source projects.

Is there a reason for this change? Running a regex over this field seems kind of pointless.

[IlluminatiFish]

Hi,

Please follow the proper contribution guidelines before making a PR to open source projects.

Is there a reason for this change? Running a regex over this field seems kind of pointless.

To be frankly honest the contributing.md was hidden in the .github folder, my bad for not looking for it more in depth.
I think running a regex over the field would be more beneficial as it is more lenient on the webhook url format

[HassanAbouelela]

The contributing guidelines are placed in the recommended folder, as per github's instructions, to ensure they show up in the side bar or when you try to open a PR.

As for using the regex here, I don't think it makes sense to add. The only benefit it has over the current implementation is that it enables the discordapp domain, and enables the specification of API version, neither of which you'll get unless you try to type the URL manually. If you copy the URL from inside the app, it'll be of the form [canary|ptb].discord.com/api/webhook, which will work with the current implementation. The disadvantages to this regex is that it's very hard to read (especially because you didn't use a raw string), and it's less performant than the text lookup.

[IlluminatiFish]

The contributing guidelines are placed in the recommended folder, as per github's instructions, to ensure they show up in the side bar or when you try to open a PR.

As for using the regex here, I don't think it makes sense to add. The only benefit it has over the current implementation is that it enables the discordapp domain, and enables the specification of API version, neither of which you'll get unless you try to type the URL manually. If you copy the URL from inside the app, it'll be of the form [canary|ptb].discord.com/api/webhook, which will work with the current implementation. The disadvantages to this regex is that it's very hard to read (especially because you didn't use a raw string), and it's less performant than the text lookup.

Will keep that noted for next time when looking for the contributing guidelines.
Fair enough, i guess we can close this out.