Fix Exploits In Code Type Questions#145
Merged
Merged
Conversation
Patching just `sys.stdout` allowed users to still access stdout via `sys.__stdout__`. The same was true for stderr. Both have been explicitly patched now. Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
Change the exception handler in the unittest template to handle BaseExceptions that don't inherit from Exception. Additionally, account for user invoked system exits. Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
HassanAbouelela
added
P2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR hardens our snekbox script template against a few possible exploits that can force snekbox to pass failing code.