Form responses storing and validation#17
Merged
Conversation
ks129
added
area: validation
ghost
added
the
jb3
previously approved these changes
Dec 9, 2020
Member
|
Wrong button, meant to request changes! |
jb3
requested changes
Dec 9, 2020
Member
jb3
left a comment
jb3
left a comment
There was a problem hiding this comment.
Comments made above!
This PR looks good and seems like a good base for form responses. Once this is through I'll get to work looking at how to render these forms on the frontend in a good way and how to collect responses.
Thanks!
Member
|
There are a couple of other places where status codes should be returned. We'll also standardise the error format at some point. Don't worry about those, implement the changes in this PR and I'll open a PR in the next day or so to change things — but they are not critical. |
Co-authored-by: Joe Banks <joseph@josephbanks.me>
jb3
approved these changes
Dec 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8
Created models for form responses, added captcha and blacklist validation and updated user validation. Now also stores data to DB.
Also added duplicate ID validation for forms as side change (found bug when testing).