Allow Setup For Unittests#179
Merged
HassanAbouelela merged 2 commits intomainfrom Jun 24, 2022
Merged
Conversation
Adds the setup method as a special method for unittest question types. Additionally, a couple QoL fixes are included. I changed `unit` to `self` to clarify what it actually is, and I changed an `lstrip` to a `removeprefix` to avoid removing unintentional portions of the name (for instance `something` -> `omething`) Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
HassanAbouelela
added
P0
HassanAbouelela
force-pushed
the
add-setup
branch
from
f3b53a1 to
9d47002
Compare
Contributor
Author
|
I've now added another change. Test methods are now async, more details in the commit |
The codejam test suite uses async functions, which would be annoying to deal with in our current template. Switching to async makes that available to those who want it, without affecting those who don't. Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
HassanAbouelela
force-pushed
the
add-setup
branch
from
9d47002 to
0befbe9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the setup method as a special method for unittest question types. Additionally, a couple QoL fixes are included. I changed
unittoselfto clarify what it actually is, and I changed anlstripto aremoveprefixto avoid removing unintentional portions of the name (for instancesomething->omething)This will require migrating a few database entries by hand, so hold off on merging till that is ready.