Skip to content

Create route for showing single form response#22

Merged
jb3 merged 3 commits into
mainfrom
ks123/single-response-route
Dec 14, 2020
Merged

Create route for showing single form response#22
jb3 merged 3 commits into
mainfrom
ks123/single-response-route

Conversation

@ks129
Copy link
Copy Markdown
Contributor

@ks129 ks129 commented Dec 13, 2020

Admin-only route. Closes #19

@ks129 ks129 added area: admin Code relating to admin functionality like creating and reading form responses. area: route Code that will create a new route on the web application. area: form submission Code relating to the response submission to forms backend. labels Dec 13, 2020
@ks129 ks129 requested a review from jb3 as a code owner December 13, 2020 12:23
@ghost ghost added the needs 1 approval label Dec 13, 2020
Copy link
Copy Markdown
Member

@jb3 jb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a think about this, maybe we should integrate the other issue about having a list of all responses into this as well (this ticket).

We should namespace these like so:
/forms/{form_id:str}/responses - return all responses
/forms/{form_id:str}/responses/{response_id:str} - return a single response

This makes the frontend interaction much clearer.

@ks129 ks129 requested a review from jb3 December 14, 2020 11:59
Copy link
Copy Markdown
Member

@jb3 jb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking sweet!

@ghost ghost removed the needs 1 approval label Dec 14, 2020
@jb3 jb3 merged commit ff5be5d into main Dec 14, 2020
@jb3 jb3 deleted the ks123/single-response-route branch December 14, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: admin Code relating to admin functionality like creating and reading form responses. area: form submission Code relating to the response submission to forms backend. area: route Code that will create a new route on the web application.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add route for fetching a response by ID

2 participants