Sourcery refactored main branch

[sourcery-ai]

Branch main refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the main branch, then run:

git fetch origin sourcery/main
git merge --ff-only FETCH_HEAD
git reset HEAD^

[ghost]

Thank you for contributing to Python Discord!

Please check out the following documents:

• Join the Discord server! - If you have not already, join the Discord server and introduce yourself in our #dev-contrib channel.
• Python Discord Code of Conduct – Code of conduct for our community
• Python Discord Contributor Wiki - A set of resources about setting up our services

[sourcery-ai]

Function create_route_map refactored with the following changes:

• Inline variable that is immediately returned (inline-immediately-returned-variable)
• Merge nested if conditions (merge-nested-ifs)

[sourcery-ai]

Function Form.validate_features refactored with the following changes:

• Invert any/all to simplify comparisons (invert-any-all)
• Replace list(), dict() or set() with comprehension (collection-builtin-to-comprehension)

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 3.26%.

Quality metrics	Before	After	Change
Complexity	15.76 🙂	12.36 🙂	-3.40 👍
Method Length	56.33 ⭐	55.17 ⭐	-1.16 👍
Working memory	10.39 😞	10.11 😞	-0.28 👍
Quality	57.40% 🙂	60.66% 🙂	3.26% 👍

Other metrics	Before	After	Change
Lines	95	96	1

Changed files	Quality Before	Quality After	Quality Change
backend/route_manager.py	46.89% 😞	50.91% 🙂	4.02% 👍
backend/models/form.py	72.64% 🙂	73.81% 🙂	1.17% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
backend/route_manager.py	create_route_map	22 😞	131 😞	13 😞	40.57% 😞	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
backend/models/form.py	Form.dict	9 🙂	54 ⭐	10 😞	67.06% 🙂	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.