Make import name of route working for every platform#28
Merged
Conversation
As Windows use \\ instead /, current way doesn't work in Windows, because replacing / with . doesn't do anything with \\. Now this join parent parts instead, what doesn't include separations.
ghost
added
the
Fix missing type annotation Lint fix
Refactor `create_route_map`
jb3
requested changes
Dec 15, 2020
| return value | ||
|
|
||
| def dict(self, admin: bool = True, **kwargs: t.Dict) -> t.Dict[str, t.Any]: | ||
| def dict(self, admin: bool = True, **kwargs: t.Any) -> dict[str, t.Any]: |
Member
There was a problem hiding this comment.
Why would kwargs be t.Any? Wouldn't it make more sense to be dict[str, t.Any]?
Member
There was a problem hiding this comment.
cc @decorator-factory since I think this is a refactor.
Contributor
There was a problem hiding this comment.
@jb3 kwargs are hinted by the type of the values: https://mypy.readthedocs.io/en/stable/cheat_sheet_py3.html#when-you-re-puzzled-or-when-things-are-complicated
Contributor
There was a problem hiding this comment.
Just like *args are not hinted as tuple[str, ...], but as str
This reverts commit eb413d6.
jb3
approved these changes
Dec 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As Windows use
\\instead/, current way doesn't work in Windows, because replacing/with.doesn't do anything with\\.Now this join parent parts instead, what doesn't include separations.
Edit: Decided with @decorator-factory to merge some refactors here, more details in commits.