Skip to content

Modify Patch Behavior#43

Merged
jb3 merged 2 commits into
mainfrom
modify-patch-behavior
Dec 22, 2020
Merged

Modify Patch Behavior#43
jb3 merged 2 commits into
mainfrom
modify-patch-behavior

Conversation

@HassanAbouelela
Copy link
Copy Markdown
Contributor

Closes this notion ticket.

Changes the patch route behavior for dicts, so we don't need to include full objects whenever we update them. Does not affect behavior for other primitives or containers.

Additionally removes the meta object, and moves webhooks under the main form object for the reasons described in the ticket.

Removes the meta object, and moves the webhook object under the main
form object to reduce nesting.

Signed-off-by: Hassan Abouelela <47495861+HassanAbouelela@users.noreply.github.com>
Changes the patching strategy to modify certain objects instead of
 outright overwriting them.

Signed-off-by: Hassan Abouelela <47495861+HassanAbouelela@users.noreply.github.com>
@HassanAbouelela HassanAbouelela added area: admin Code relating to admin functionality like creating and reading form responses. P1 High priority tasks. type: feature A new feature that should be added to the application. labels Dec 22, 2020
Copy link
Copy Markdown
Member

@jb3 jb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff!

@jb3 jb3 merged commit a7dd78e into main Dec 22, 2020
@jb3 jb3 deleted the modify-patch-behavior branch December 22, 2020 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: admin Code relating to admin functionality like creating and reading form responses. P1 High priority tasks. type: feature A new feature that should be added to the application.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants