Skip to content

Add ESLint formatter for GHA annotations and add it to workflow#133

Merged
jb3 merged 6 commits into
mainfrom
github-annotations-eslint
Feb 10, 2021
Merged

Add ESLint formatter for GHA annotations and add it to workflow#133
jb3 merged 6 commits into
mainfrom
github-annotations-eslint

Conversation

@ks129
Copy link
Copy Markdown
Contributor

@ks129 ks129 commented Feb 8, 2021

This PR creates a new ESLint formatter that outputs errors in GHA annotations format. Also added this to workflow.

@ks129 ks129 added the area: CI Continuous Integration and Continuous Deployment label Feb 8, 2021
@ks129
Copy link
Copy Markdown
Contributor Author

ks129 commented Feb 8, 2021

Screenshot 2021-02-08 at 20 56 56
Here is proof.

@ks129 ks129 marked this pull request as ready for review February 8, 2021 18:58
@ks129 ks129 requested a review from jb3 as a code owner February 8, 2021 18:58
Comment thread annotations_formatter.js
@@ -0,0 +1,14 @@
module.exports = function (results) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this file should be in a subfolder, such as .github/workflow.

@jb3 jb3 merged commit e99a420 into main Feb 10, 2021
@jb3 jb3 deleted the github-annotations-eslint branch February 10, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: CI Continuous Integration and Continuous Deployment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants