Discord OAuth#141
Merged
Merged
Conversation
Moves all authorization functionality to a new file, and adds a helper to send discord OAuth code to the backend, and set JWT. Adds a library to read and set cookies. Signed-off-by: Hassan Abouelela <47495861+HassanAbouelela@users.noreply.github.com>
Removes OAuth button from home page, and redesigns it. Uses new authorization functionality in auth. Signed-off-by: Hassan Abouelela <47495861+HassanAbouelela@users.noreply.github.com>
Signed-off-by: Hassan Abouelela <47495861+HassanAbouelela@users.noreply.github.com>
Dynamically displays an auth button in place of the submit button if needed, and adds full authorization flow. Signed-off-by: Hassan Abouelela <47495861+HassanAbouelela@users.noreply.github.com>
HassanAbouelela
added
priority: high
status: stalled
Signed-off-by: Hassan Abouelela <47495861+HassanAbouelela@users.noreply.github.com>
Signed-off-by: Hassan Abouelela <47495861+HassanAbouelela@users.noreply.github.com>
HassanAbouelela
force-pushed
the
discord-oauth
branch
from
7fab6fb to
2229ba9
Compare
Signed-off-by: Hassan Abouelela <47495861+HassanAbouelela@users.noreply.github.com>
HassanAbouelela
force-pushed
the
discord-oauth
branch
from
6b4b802 to
cde3272
Compare
Signed-off-by: Hassan Abouelela <47495861+HassanAbouelela@users.noreply.github.com>
HassanAbouelela
force-pushed
the
discord-oauth
branch
from
cde3272 to
fdb06b4
Compare
Signed-off-by: Hassan Abouelela <47495861+HassanAbouelela@users.noreply.github.com>
Signed-off-by: Hassan Abouelela <47495861+HassanAbouelela@users.noreply.github.com> # Conflicts: # package.json # src/commonStyles.tsx # src/pages/FormPage.tsx
Adds automatic token refresh, and removes manual setting of JWT. Signed-off-by: Hassan Abouelela <47495861+HassanAbouelela@users.noreply.github.com>
HassanAbouelela
force-pushed
the
discord-oauth
branch
from
e1163ad to
604620f
Compare
Explicitly sets the path attribute of username and scope cookies, to ensure they work correctly across page transitions, and to match the actual authorization cookie. Signed-off-by: Hassan Abouelela <47495861+HassanAbouelela@users.noreply.github.com>
HassanAbouelela
removed
the
status: stalled
Extends username expiry to a very far date, to prevent it from expiring on session. Signed-off-by: Hassan Abouelela <47495861+HassanAbouelela@users.noreply.github.com>
Deploying with
|
Fixes the centering of the return home button on closed forms, by removing the style wrapper. Signed-off-by: Hassan Abouelela <47495861+HassanAbouelela@users.noreply.github.com>
Signed-off-by: Hassan Abouelela <47495861+HassanAbouelela@users.noreply.github.com> # Conflicts: # package.json # yarn.lock
HassanAbouelela
force-pushed
the
discord-oauth
branch
from
cd8748d to
5424481
Compare
jb3
requested changes
Mar 7, 2021
Member
jb3
left a comment
jb3
left a comment
There was a problem hiding this comment.
Few notes, otherwise looks good and works great.
Co-authored-by: Joe Banks <joseph@josephbanks.me>
Signed-off-by: Hassan Abouelela <47495861+HassanAbouelela@users.noreply.github.com>
jb3
approved these changes
Mar 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements Discord OAuth for this notion ticket.
python-discord/forms-backend#58 needs to be merged before this PR.