Fixes Broken Links To Assets#156
Merged
Merged
Conversation
Sets asset links to absolute paths, so they work on pages. Signed-off-by: Hassan Abouelela <47495861+HassanAbouelela@users.noreply.github.com>
jb3
approved these changes
Mar 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, links to assets in
public/were using relative paths, which works on the home page, but on subpages, such as forms, the app would try to fetch them from an incorrect location, and 404. This PR uses fixed paths for the assets to allow proper locating.Note: If your IDE complains about being unable to find the files, that's because the fixed path in the source code, and in the compiled output are different (see webpack config).