Skip to content

Bump workbox-webpack-plugin from 6.1.0 to 6.1.1#174

Merged
HassanAbouelela merged 1 commit into
mainfrom
dependabot/npm_and_yarn/workbox-webpack-plugin-6.1.1
Mar 7, 2021
Merged

Bump workbox-webpack-plugin from 6.1.0 to 6.1.1#174
HassanAbouelela merged 1 commit into
mainfrom
dependabot/npm_and_yarn/workbox-webpack-plugin-6.1.1

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Mar 6, 2021

Bumps workbox-webpack-plugin from 6.1.0 to 6.1.1.

Release notes

Sourced from workbox-webpack-plugin's releases.

Workbox v6.1.1 includes a bug fix for the NetworkFirst strategy, as well as some documentation and TypeScript fixes.

🐛 What's Fixed?

workbox-strategies

The NetworkFirst strategy uses two promises: one for the network request, and one is the optional networkTimeoutSeconds option is set. If the network request succeeds, then the timeout promise's timer is canceled. However, the strategy previously attempted to wait until both promises resolve before the handler resolves. This meant that, if the network request succeeds before the timeout, the strategy's over handler promise would not properly resolve.

See #2744

Thanks!

Special thanks to @​joshkel for both bringing that NetworkFirst issue to our attention, as well as contributing the code for the fix!

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot Bot requested a review from jb3 as a code owner March 6, 2021 19:34
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Mar 6, 2021

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7d48129
Status:               ✅  Deploy successful!
Preview URL:    https://d25d3572.forms-frontend.pages.dev
View logs

Bumps [workbox-webpack-plugin](https://github.com/googlechrome/workbox) from 6.1.0 to 6.1.1.
- [Release notes](https://github.com/googlechrome/workbox/releases)
- [Commits](GoogleChrome/workbox@v6.1.0...v6.1.1)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot force-pushed the dependabot/npm_and_yarn/workbox-webpack-plugin-6.1.1 branch from b39e1c9 to 7d48129 Compare March 7, 2021 00:33
@HassanAbouelela HassanAbouelela merged commit ad212a9 into main Mar 7, 2021
@HassanAbouelela HassanAbouelela deleted the dependabot/npm_and_yarn/workbox-webpack-plugin-6.1.1 branch March 7, 2021 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant