Skip to content

Use backend API for front page (forms listing)#30

Merged
jb3 merged 11 commits into
mainfrom
ks123/discovery
Dec 14, 2020
Merged

Use backend API for front page (forms listing)#30
jb3 merged 11 commits into
mainfrom
ks123/discovery

Conversation

@ks129
Copy link
Copy Markdown
Contributor

@ks129 ks129 commented Dec 14, 2020

  • Updated models to match changes in backend.
  • Made getForms using API instead hard-coded values.
  • Installed Axios and made global client.
  • Sorry, I never used jest, so I don't know well how to write tests. I made that current tests don't fail, but I can't create new ones.

@ks129 ks129 requested a review from jb3 December 14, 2020 18:26
@ghost ghost added the needs 1 approval label Dec 14, 2020
Copy link
Copy Markdown
Member

@jb3 jb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change regarding the environment

Comment thread src/api/client.ts
Co-authored-by: Joe Banks <joseph@josephbanks.me>
@ghost ghost removed the needs 1 approval label Dec 14, 2020
@jb3 jb3 merged commit a1963eb into main Dec 14, 2020
@jb3 jb3 deleted the ks123/discovery branch December 14, 2020 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants