Skip to content

Bump Dependencies#454

Merged
HassanAbouelela merged 15 commits into
mainfrom
bump-dependencies
Jun 23, 2022
Merged

Bump Dependencies#454
HassanAbouelela merged 15 commits into
mainfrom
bump-dependencies

Conversation

@HassanAbouelela
Copy link
Copy Markdown
Contributor

@HassanAbouelela HassanAbouelela commented Jun 18, 2022

I ran into an issue upgrading dependencies from dependabot, since we had a lot of upgrades that would require upgrading multiple libraries at once, even if their version specifiers don't indicate so. This was particularly true for webpack dependencies. On top of that, many things need to be bumped and rewritten in bulk, such as the react dependencies. I went through and made bumps for all those, each "group" in a commit.

Most commits have just been version changes with no code changes, but here are the ones that did change code:

  • 618ed04: Husky rewrote it's format... again... I just regenerated the same hook
  • bd47dce: The library we use for transforming SVGs in tests hasn't had an update in half a decade, and it doesn't work with the latest version of jest. We don't actually need it though, I removed it, and added a simple transformer that achieves the same thing.
  • 66cb236: We now need to set the test environment to jsdom explicitly
    • 8c286b0: jsdom-fourteen is no longer necessary, since the jsdom library published by jest has the same features, and jsdom-fourteen is archived
  • 52e6fe4: Import has been renamed
  • 5f4ddc8: Bumping react to v18. This is a large breaking change, and required updating our code. It also required updating react-related libraries such as router, which required more changes. Changelogs for both are attached in the commit
  • 5f4ddc8: weback-dev-server now uses public as default sources root, so we don't pass it anymore. Migration guide is in the commit, but it's unnecessary.

Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
Bump ESLint and related dependencies.

Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
Bump husky, and regenerate config after breaking changes.

Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
Bump fortawesome dependencies to the latest versions.

Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
The current SVG transformer has not had an update in 4 years, and breaks
with the latest jest version. The behavior can be very easily replicated
by hand, as is documented by SVGR, the library we are already using in
webpack.

Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
jsdom-fourteen was deprecated in favor of the one shipped by jest.
Switched to using that instead.

Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
Bump jest and related dependencies, and account for breaking changes.

Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
Bump react to v18, and handle all the breaking changes. This includes
bumping a lot of other dependencies to versions which support react 18,
and handling the breaking changes for those.

Refer to the following documents for migration guides:
React: https://reactjs.org/blog/2022/03/08/react-18-upgrade-guide.html
Router: https://reactrouter.com/docs/en/v6/upgrading/v5

Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
@HassanAbouelela
Copy link
Copy Markdown
Contributor Author

Netlify is being wonderful and using node 12. I've bumped us up to 16.

Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0c63a1c
Status:⚡️  Build in progress...

View logs

@HassanAbouelela HassanAbouelela marked this pull request as ready for review June 18, 2022 22:17
@HassanAbouelela HassanAbouelela requested a review from jb3 as a code owner June 18, 2022 22:17
@HassanAbouelela HassanAbouelela merged commit 7aa707d into main Jun 23, 2022
@HassanAbouelela HassanAbouelela deleted the bump-dependencies branch June 23, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant