Display Test Failures & Refactor Formpage#474
Merged
Conversation
HassanAbouelela
added
area: front-end
priority: critical
type: enhancement
✅ Deploy Preview for pydis-forms ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
whispersofthedawn
previously approved these changes
Jun 30, 2022
Add transitions to the error message component, and allow more flexibility by allowing the caller to specify the inner component of the message. Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
The main FormPage component had gotten very out of hand, with many moving parts that were hard to parse, understand, or modify. This refactors breaks things up into separate files with better defined goals. Most changes are just straight copies without much change, however some structural changes have been introduced as a foundation for improving the app. Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
HassanAbouelela
force-pushed
the
display-test-failures
branch
from
016bce4 to
acb7df2
Compare
Deploying with
|
| Latest commit: |
b83dff7
|
| Status: | ⚡️ Build in progress... |
MarkKoz
reviewed
Jun 30, 2022
Unify the string and element types on the interface to clarify they are mutually exclusive. Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
Uses an interface to define the RenderedQuestion component state, to reduce the required type and existence checks in the rest of the codebase. Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
MarkKoz
approved these changes
Jul 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes a few things:
Note: I've tagged this as critical, since it dips it's toes into about half the codebase, and other PRs would likely create painful conflicts 😄. Also CJ is active now, and this would be nice to have.