Skip to content

Authorization pop-up & misc improvements#634

Merged
jb3 merged 9 commits into
mainfrom
jb3/auth/popup-and-improvements
Jul 10, 2024
Merged

Authorization pop-up & misc improvements#634
jb3 merged 9 commits into
mainfrom
jb3/auth/popup-and-improvements

Conversation

@jb3
Copy link
Copy Markdown
Member

@jb3 jb3 commented Jul 9, 2024

  • Authorization window with Discord is now a pop-up instead of a new tab, more
    in keeping with other services that use OAuth2.
  • State is now a longer cryptographically secure nonce, as opposed to our
    previous short numeric states.
  • When authorizing, we now dim the entire form tab until the authorization has
    been completed/cancelled
  • We now have an application-wide Redux store if we want to do anything fancy in
    future related to application state

@jb3 jb3 requested a review from ks129 as a code owner July 9, 2024 19:35
@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 9, 2024

Deploy Preview for pydis-forms ready!

Name Link
🔨 Latest commit e586c95
🔍 Latest deploy log https://app.netlify.com/sites/pydis-forms/deploys/668ddc4fcc26eb000803a4d5
😎 Deploy Preview https://deploy-preview-634--pydis-forms.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jb3 jb3 force-pushed the jb3/auth/popup-and-improvements branch from adbc408 to f77c39a Compare July 9, 2024 19:51
ChrisLovering
ChrisLovering previously approved these changes Jul 9, 2024
@jb3 jb3 force-pushed the jb3/auth/popup-and-improvements branch 2 times, most recently from a2a37ba to 334b150 Compare July 9, 2024 20:55
@jb3 jb3 force-pushed the jb3/auth/popup-and-improvements branch from 334b150 to e586c95 Compare July 10, 2024 00:56
@jb3 jb3 merged commit d96ea39 into main Jul 10, 2024
@jb3 jb3 deleted the jb3/auth/popup-and-improvements branch July 10, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants