Skip to content

Modify Sentry Functionality#99

Merged
jb3 merged 3 commits into
mainfrom
fix-sentry-sourcemaps
Jan 21, 2021
Merged

Modify Sentry Functionality#99
jb3 merged 3 commits into
mainfrom
fix-sentry-sourcemaps

Conversation

@HassanAbouelela
Copy link
Copy Markdown
Contributor

@HassanAbouelela HassanAbouelela commented Jan 20, 2021 •
edited
Loading

This PR modifies the sentry setup to add a few features:

  • Fixes source map setup for tracing
  • Adds release tags to aid in filtering
  • Fixes release SHAs for PRs
  • Adds stack trace linking on the site (thanks Joe!)

@HassanAbouelela HassanAbouelela added area: CI Continuous Integration and Continuous Deployment type: enhancement Changes or improvements to existing features labels Jan 20, 2021
@HassanAbouelela

This comment has been minimized.

Sign in to view
@HassanAbouelela HassanAbouelela marked this pull request as draft January 20, 2021 07:59
@HassanAbouelela HassanAbouelela changed the title Fix Sentry Source Map Directory Modify Sentry Functionality Jan 20, 2021
@HassanAbouelela
Corrects SHA & Path In Workflow
5ba6e83 
Changes the sourcemap path to point to the location it is compiled to.
Dynamically determines the correct SHA to use for program compilation
and sentry release as it was incorrect for PRs due to the way github
actions work.

Signed-off-by: Hassan Abouelela <47495861+HassanAbouelela@users.noreply.github.com>
@HassanAbouelela
Compiles Source Maps
7b1f6e8 
Adds source map compilation for builds. Additionally, simplifies the
file naming, and url.

Signed-off-by: Hassan Abouelela <47495861+HassanAbouelela@users.noreply.github.com>
@HassanAbouelela
Adds Sentry Release Tags
72dca9e 
Adds tags for sentry release, either containing the PR number or branch
name.

Signed-off-by: Hassan Abouelela <47495861+HassanAbouelela@users.noreply.github.com>
@HassanAbouelela HassanAbouelela marked this pull request as ready for review January 20, 2021 21:18
jb3
jb3 approved these changes Jan 21, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@jb3 jb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart, I like it.

@jb3 jb3 merged commit 26a23bf into main Jan 21, 2021
@jb3 jb3 deleted the fix-sentry-sourcemaps branch January 21, 2021 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jb3 jb3 jb3 approved these changes

@ks129 ks129 Awaiting requested review from ks129

Assignees

No one assigned

Labels

area: CI Continuous Integration and Continuous Deployment type: enhancement Changes or improvements to existing features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HassanAbouelela @jb3