Skip to content

New "M-x face" command#202

Merged
jb3 merged 3 commits into
mainfrom
jb3/features/face-generator
Jun 4, 2024
Merged

New "M-x face" command#202
jb3 merged 3 commits into
mainfrom
jb3/features/face-generator

Conversation

@jb3
Copy link
Copy Markdown
Member

@jb3 jb3 commented Jun 4, 2024

Add a new M-x face command to generate DevOps team compatible avatars given
uploaded files/attached URLs.

For several reasons, this command should not be opened wider than the DevOps
team:

  • It passes mostly untrusted URL data into ImageMagick
  • It allows for endpoints in cluster to be hit through arbitrary URL hitting
  • It runs things in a blocking context

For this reason, this command is only a bit of fun for DevOps role members and
should never be wider than that.

@jb3 jb3 force-pushed the jb3/features/face-generator branch from a15c00c to 8f2c27f Compare June 4, 2024 00:32
@ChrisLovering ChrisLovering self-requested a review June 4, 2024 00:37
@jb3 jb3 force-pushed the jb3/features/face-generator branch 2 times, most recently from 6db607b to 0db3b92 Compare June 4, 2024 00:41
Comment thread Dockerfile Outdated
Comment thread arthur/exts/systems/system_information.py Outdated
Comment thread arthur/exts/systems/system_information.py Outdated
Comment thread pyproject.toml Outdated
@jb3 jb3 force-pushed the jb3/features/face-generator branch from 0db3b92 to 236be7e Compare June 4, 2024 18:21
@jb3
Copy link
Copy Markdown
Member Author

jb3 commented Jun 4, 2024

@ChrisLovering review comments addressed.

@jb3 jb3 merged commit 0f980be into main Jun 4, 2024
@jb3 jb3 deleted the jb3/features/face-generator branch June 4, 2024 22:11
@sentry
Copy link
Copy Markdown

sentry Bot commented Jun 4, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ExtensionFailed: Extension 'arthur.exts.systems.system_information' raised an error: ImportError: MagickWand share... discord.ext.commands.bot in _load_from_module_spec View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants