Add devops rules command#27
Merged
Merged
Conversation
HassanAbouelela
approved these changes
Oct 7, 2022
ChrisLovering
force-pushed
the
devops-rukes
branch
from
ec91b53 to
56ffef2
Compare
ChrisLovering
force-pushed
the
devops-rukes
branch
2 times, most recently
from
231327e to
79a423f
Compare
ChrisLovering
force-pushed
the
devops-rukes
branch
from
79a423f to
4716123
Compare
HassanAbouelela
previously approved these changes
Oct 7, 2022
ChrisLovering
force-pushed
the
devops-rukes
branch
2 times, most recently
from
798117c to
21ea48a
Compare
ChrisLovering
force-pushed
the
devops-rukes
branch
from
21ea48a to
d475961
Compare
HassanAbouelela
approved these changes
Oct 7, 2022
Contributor
HassanAbouelela
left a comment
HassanAbouelela
left a comment
There was a problem hiding this comment.
It works well, and the implementation is really clean. This is nice. If you want to fix invalid indices before merging, feel free to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proof of functionality:
Non-devops member:
Devops member:
https://canary.discord.com/channels/267624335836053506/675756741417369640/1028031312671539260