Skip to content

Fix cronjob integrations #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisLovering merged 2 commits into from
Mar 2, 2023
Merged

Fix cronjob integrations #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d66ec20
Bump dependencies to latest
ChrisLovering Mar 2, 2023
3b70a2a
Don't use the beta1 APIs for cronjobs
ChrisLovering Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions arthur/apis/kubernetes/jobs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,23 +3,23 @@

from kubernetes_asyncio import client
from kubernetes_asyncio.client.api_client import ApiClient
from kubernetes_asyncio.client.models import V1beta1CronJob, V1beta1CronJobList, V1Job
from kubernetes_asyncio.client.models import V1CronJob, V1CronJobList, V1Job


async def list_cronjobs(namespace: Optional[str] = None) -> V1beta1CronJobList:
async def list_cronjobs(namespace: Optional[str] = None) -> V1CronJobList:
"""Query the Kubernetes API for a list of cronjobss in the provided namespace."""
async with ApiClient() as api:
api = client.BatchV1beta1Api(api)
api = client.BatchV1Api(api)
if namespace:
return await api.list_namespaced_cron_job(namespace)
else:
return await api.list_cron_job_for_all_namespaces()


async def get_cronjob(namespace: str, cronjob_name: str) -> V1beta1CronJob:
async def get_cronjob(namespace: str, cronjob_name: str) -> V1CronJob:
"""Fetch a cronjob given the name and namespace."""
async with ApiClient() as api:
api = client.BatchV1beta1Api(api)
api = client.BatchV1Api(api)
return await api.read_namespaced_cron_job(cronjob_name, namespace)


Expand Down
Loading