This repository was archived by the owner on Aug 14, 2023. It is now read-only.
Correct capitalization of environment variable name.#101
Merged
Conversation
When I initially deployed this, I used an uppercase variable name as later versions of the Prometheus client library (all of which I am using in various of my projects) switched to uppercase and deprecated the old way of specifying this variable. Unfortunately the `django-prometheus` library uses a lowercase variable to check whether the multiprocess mode is in use, so we were collecting per-worker metrics the entire time, which completely messed up our time series.
jb3
approved these changes
Sep 23, 2021
Member
|
i'm still angry about this |
|
After seeing the hook trigger in Discord, I have joined you in being angered. |
Contributor
Author
|
Fully agree. This also angers me daily. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I initially deployed this, I used an uppercase variable name as
later versions of the Prometheus client library (all of which I am using
in various of my projects) switched to uppercase and deprecated the old
way of specifying this variable. Unfortunately the
django-prometheuslibrary uses a lowercase variable to check whether the multiprocess mode
is in use, so we were collecting per-worker metrics the entire time,
which completely messed up our time series.