-
-
Notifications
You must be signed in to change notification settings - Fork 4
Update the contributing guides #60
Copy link
Copy link
Closed
Labels
area: featuresRelated to a feature in the communityRelated to a feature in the communitystatus: deferredWill be done at a later timeWill be done at a later time
Metadata
Metadata
Assignees
Labels
area: featuresRelated to a feature in the communityRelated to a feature in the communitystatus: deferredWill be done at a later timeWill be done at a later time
Type
Fields
Give feedbackNo fields configured for issues without a type.
On windows, docker is now handled through docker desktop which already comes with compose installed making the docker compose requirement for the projects extraneous on the platform.
In https://pythondiscord.com/pages/contributing/hosts-file/, the guide refers windows users to use the
docker-machine ip defualtcommand, which is no longer available with docker desktop.The IP used by docker is stored in the hosts file which needs to be edited anyway so the guide can direct there for it. Or the IP is already pointed at by
host.docker.internalin the hosts file which could also be added to the site's allowed hosts and used instead of thepythondiscord.localdomain name. This will also keep everything working in case docker decides to change it. The docker domain name is not available on linux docker/for-linux#264The mac docker environment also seems to have been changed but I don't have a way of looking at that