Start refreshing refresh tokens#126
Merged
Merged
Conversation
Refresh tokens still don't automatically get invalidated and expire, but when a request to generate a new access token is made the refresh token is potentially also renewed.
Bluenix2
added
area: back-end
type: enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request means that refresh tokes now refresh when generating new access tokens.
Currently I have set the lifetime of a refresh token to be the lifetime of 6 access tokens (6 hours). This means that 6 hours after a refresh token has been generated, it will be refresh when trying to generate a new access token. When this happens the old is invalidated, but this is not done automatically. So you can wait several days, and the refresh token won't be invalidated until you try to generate an access token to use.