Clean Up AOC logging#1016
Merged
Merged
Conversation
This commit moves the logging constants from the Client class to a new Logging class. Flake8 is renabled for constants, and the error it was disabled for was specifically ignored. All new errors were fixed. It also fixes a bug with __all__, which was trying to export a missing symbol due to a missing comma. Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
The AOC cog produces a lot of large logs very frequently which have minimal value, causing the logs to be significantly harder to navigate. Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
HassanAbouelela
added
status: approved
ChrisLovering
approved these changes
Jan 25, 2022
Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
HassanAbouelela
force-pushed
the
aoc-logging
branch
from
db52867 to
d6e483a
Compare
Contributor
Author
|
The actions are currently failing for an unknown reason. We've identified that there was a minor version bump from 3.9.9 to 3.9.10, but the cause of the failure, and the solution remain unknown. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant Issues
Approved by myself.
Description
When browsing the prod logs looking for a specific error, I noticed that the AOC cog produced a bunch of mostly pointless logs which contributed heavily to making the logs unbrowsable. This PR removes the main offenders while not losing any important information.
This PR adds a few unrelated changes to the config, but they are minor and should be good overall. The commit message for those changes should explain everything.
Did you: