Python 3.10 & bot-core migration#1092
Merged
Merged
Conversation
ChrisLovering
requested review from
Den4200,
SebastiaanZ and
ks129
as code owners
ChrisLovering
added
priority: 1 - high
ChrisLovering
force-pushed
the
bot-core-migration
branch
3 times, most recently
from
22cf4e2 to
ce407f9
Compare
Xithrius
requested review from
Bluenix2,
HassanAbouelela and
jchristgit
and removed request for
Den4200 and
ks129
ChrisLovering
force-pushed
the
bot-core-migration
branch
4 times, most recently
from
c55deb4 to
a9c4778
Compare
ChrisLovering
added a commit
that referenced
this pull request
Aug 28, 2022
1<<15 is the flag for message content intent, so adding this value to the intents value hard codes that to always be enabled. Doing it this way also bypasses the need to patch the flags themselvse in discord.py. This is required until #1092 is merged.
4 tasks
ChrisLovering
force-pushed
the
bot-core-migration
branch
from
a9c4778 to
aec74a6
Compare
ChrisLovering
force-pushed
the
bot-core-migration
branch
from
aec74a6 to
a84b743
Compare
wookie184
reviewed
Sep 18, 2022
This is to avoid needed to use wait_until_guild_available during the setup hook.
ChrisLovering
force-pushed
the
bot-core-migration
branch
from
0cd7f30 to
3578e97
Compare
Member
Author
|
Rebased onto main. Looking at the diff there are no conflicting changes |
This moves away from an infinite loop, to a task scheduling approach. Doing it this way avoids an infinitely running cog_load
HassanAbouelela
approved these changes
Sep 23, 2022
Contributor
HassanAbouelela
left a comment
HassanAbouelela
left a comment
There was a problem hiding this comment.
This was a big PR. Some would say it was too big. Others are simply wrong.
Xithrius
removed
the
status: needs review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This bumps the bot up to 3.10, bumps all deps. The bumped deps include bot-core which comes with a move to the stable Discord.py 2.0 release.
Sir-Lancebot never had the async cog loading treatment, so this PR also includes that.
There are also miscellaneous fixes included in here for breaking changes in dep bumps.
Something worth mentioning is that I had to change our approach to dry running the bot in CI, see ab218f2. This is because cog laoding is managed by bot-core in the bot's setup_hook, which is called after logging in. Obviously we don't want to give CI a bot token, so these changes were required.
This new approach does output some warnings, see the recent successful action, which can safely be ignored, but may confuse users if they actually get an error in that step, and see all the extra output.
Did you: