Skip to content

Fix hacktoberfest-issues bug#1112

Merged
ChrisLovering merged 2 commits into
mainfrom
fix-issue-1107
Oct 2, 2022
Merged

Fix hacktoberfest-issues bug#1112
ChrisLovering merged 2 commits into
mainfrom
fix-issue-1107

Conversation

@TizzySaurus
Copy link
Copy Markdown
Contributor

Relevant Issues

Closes #1107.

Description

As described in the issue, the value of the body key returned by the API can be a literal null value, meaning dict.get("body", "") won't substitute as the key does exist. Instead, we now use dict.get("body") or "".

Did you:

@TizzySaurus TizzySaurus added type: bug Something isn't working area: backend Related to internal functionality and utilities status: needs review Author is waiting for someone to review and approve category: events Related to events (AoC, Hacktoberfest) labels Oct 2, 2022
@TizzySaurus TizzySaurus requested a review from ks129 as a code owner October 2, 2022 14:38
Copy link
Copy Markdown
Contributor

@wookie184 wookie184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@ChrisLovering ChrisLovering merged commit fb3cae9 into main Oct 2, 2022
@ChrisLovering ChrisLovering deleted the fix-issue-1107 branch October 2, 2022 16:15
@Xithrius Xithrius removed the status: needs review Author is waiting for someone to review and approve label Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: backend Related to internal functionality and utilities category: events Related to events (AoC, Hacktoberfest) type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError: object of type 'NoneType' has no len()

4 participants