Skip to content

updated bot/exts/core/help.py for Issue #1122#1137

Merged
wookie184 merged 1 commit into
python-discord:mainfrom
DivyanshuBist:bug-issue1122-message-of-type-None
Oct 30, 2022
Merged

updated bot/exts/core/help.py for Issue #1122#1137
wookie184 merged 1 commit into
python-discord:mainfrom
DivyanshuBist:bug-issue1122-message-of-type-None

Conversation

@DivyanshuBist
Copy link
Copy Markdown
Contributor

Relevant Issues

Closes#1122

Description

updated bot/exts/core/help.py file is updated as discussed in issue#1122

Did you:

@whispersofthedawn whispersofthedawn linked an issue Oct 29, 2022 that may be closed by this pull request
@Xithrius Xithrius added area: backend Related to internal functionality and utilities status: needs review Author is waiting for someone to review and approve type: enhancement Changes or improvements to existing features category: core Related to core functionality labels Oct 29, 2022
Copy link
Copy Markdown
Contributor

@TizzySaurus TizzySaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, good job :)

Also tested this locally w/ a asyncio.sleep(5) in build_page() to simulate the race condition that caused the error this is solving, and it no longer occurs!

Copy link
Copy Markdown
Contributor

@wookie184 wookie184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wookie184 wookie184 merged commit a76d922 into python-discord:main Oct 30, 2022
@Xithrius Xithrius removed the status: needs review Author is waiting for someone to review and approve label Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: backend Related to internal functionality and utilities category: core Related to core functionality type: enhancement Changes or improvements to existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AttributeError: 'NoneType' object has no attribute 'id'

5 participants