Add support for latex rendering server >400 errors#1278
Merged
Xithrius merged 9 commits intoJun 6, 2023
Conversation
shtlrs
reviewed
May 25, 2023
shtlrs
reviewed
May 25, 2023
shtlrs
requested changes
May 26, 2023
shtlrs
requested changes
May 27, 2023
Contributor
shtlrs
left a comment
shtlrs
left a comment
There was a problem hiding this comment.
Looks great ! Just one last comment.
Xithrius
approved these changes
Jun 6, 2023
Contributor
Xithrius
left a comment
Xithrius
left a comment
There was a problem hiding this comment.
LGTM as well. Thanks for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant Issues & Changes
Closes #1146
I've added a catch for
ClientResponseError, raised aLatexServerErrorand handled the later to return a user message, with a tiny refactoring of the code that creates the embed (in case of error)Did you: