Implemented .prideanthem command#227
Merged
Merged
Conversation
lemonsaurus
requested changes
Jun 19, 2019
Contributor
lemonsaurus
left a comment
lemonsaurus
left a comment
There was a problem hiding this comment.
Overall this looks great. I've got a couple of changes I'd like to see before I approve. Nice work on it.
Added namespaces for json loading and random choices. Changed Path() to take a direct path instead of an argument separated path. Added aliases "anthem" and "pridesong". Added periods to the end of all doc strings.
lemonsaurus
previously approved these changes
Jun 19, 2019
MarkKoz
requested changes
Jun 19, 2019
SebastiaanZ
suggested changes
Jun 19, 2019
MarkKoz
approved these changes
Jun 21, 2019
SebastiaanZ
approved these changes
Jun 21, 2019
Contributor
SebastiaanZ
left a comment
SebastiaanZ
left a comment
There was a problem hiding this comment.
Nice, thanks for all the hard work you've put in!
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will allow users to send .prideanthem with an optional genre supplied to receive a random anthem. If there are no videos for the supplied genre, it will let the user know.