Add random spooky gif feature#37
Merged
Merged
Conversation
lemonsaurus
requested changes
Oct 10, 2018
Contributor
lemonsaurus
left a comment
lemonsaurus
left a comment
There was a problem hiding this comment.
This looks mostly reasonable. I would like to test before I approve.
Contributor
Author
|
Alright, resolved the requested changes. Feel free to test. |
sco1
suggested changes
Oct 14, 2018
Contributor
sco1
left a comment
sco1
left a comment
There was a problem hiding this comment.
A few minor changes, would like to see some appropriate logging as well now that logging is set up for the bot.
Otherwise, should be good to go
Contributor
|
Any progress on the requested changes? |
Contributor
Author
|
@sco1 Sorry, I'm currently on vacation and have no PC access. Will get this done soon. |
2 tasks
kovaceviccz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #8, adding random spooky gif feature that takes use of the GIPHY API.
To take use of this cog, create a env. variable named GIPHY_TOKEN and use the token you get from https://developers.giphy.com, they have a very simple process of creating an app, just create an account and you should be able to make your app and get the API key.