Skip to content

Sentry SDK version bump, integrations adding and Sentry release workflow#547

Merged
ks129 merged 12 commits into
masterfrom
ks123/sentry
Dec 20, 2020
Merged

Sentry SDK version bump, integrations adding and Sentry release workflow#547
ks129 merged 12 commits into
masterfrom
ks123/sentry

Conversation

@ks129
Copy link
Copy Markdown
Contributor

@ks129 ks129 commented Dec 19, 2020

Relevant Issues

Approved in #dev-core.

Description

  • Bumped Sentry SDK version from 0.14 to 0.19.
  • Added Redis and aiohttp integrations to Sentry SDK initializing.
  • Added workflow for creating Sentry releases (based on site's one).

Did you:

  • Join the Python Discord Community?
  • If dependencies have been added or updated, run pipenv lock?
  • Lint your code (pipenv run lint)?
  • Set the PR to allow edits from contributors?

@ks129 ks129 added area: backend Related to internal functionality and utilities area: CI Related to continuous intergration and deployment area: dependencies Related to package dependencies and management labels Dec 19, 2020
@ghost ghost added the needs 2 approvals label Dec 19, 2020
Copy link
Copy Markdown
Member

@jb3 jb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really be initialising the Sentry SDK with the release label. I think @lemonsaurus implemented this on site so we should look there for how the SHA is fetched (we can either use a .git folder or inject the SHA into the Docker build, I think I prefer the latter) and passed into the Sentry SDK.

@ghost ghost added status: waiting for author Waiting for author to address a review or respond to a comment and removed needs 2 approvals labels Dec 19, 2020
@ghost ghost added needs 2 approvals and removed status: waiting for author Waiting for author to address a review or respond to a comment labels Dec 19, 2020
Comment thread bot/__main__.py Outdated
Comment thread bot/__main__.py Outdated
@ghost ghost added status: waiting for author Waiting for author to address a review or respond to a comment and removed needs 2 approvals labels Dec 19, 2020
@ghost ghost added needs 2 approvals and removed status: waiting for author Waiting for author to address a review or respond to a comment labels Dec 19, 2020
@ks129 ks129 requested a review from jb3 December 19, 2020 17:27
@ghost ghost removed the needs 1 approval label Dec 20, 2020
@ks129 ks129 merged commit 1cdcd23 into master Dec 20, 2020
@ks129 ks129 deleted the ks123/sentry branch December 20, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: backend Related to internal functionality and utilities area: CI Related to continuous intergration and deployment area: dependencies Related to package dependencies and management

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants