Sentry SDK version bump, integrations adding and Sentry release workflow#547
Merged
Conversation
jb3
requested changes
Dec 19, 2020
Member
jb3
left a comment
There was a problem hiding this comment.
We should really be initialising the Sentry SDK with the release label. I think @lemonsaurus implemented this on site so we should look there for how the SHA is fetched (we can either use a .git folder or inject the SHA into the Docker build, I think I prefer the latter) and passed into the Sentry SDK.
jb3
requested changes
Dec 19, 2020
Co-authored-by: Joe Banks <joseph@josephbanks.me>
jb3
approved these changes
Dec 19, 2020
MarkKoz
approved these changes
Dec 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant Issues
Approved in #dev-core.
Description
0.14to0.19.Did you:
pipenv lock?pipenv run lint)?