Get env vars from .env file

[ChrisLovering]

Description

Removed explicit mentioned of env vars from docker compose, replaced with an env_file

Reasoning

This means users of the docker-compose workflow won't need to worry about accidentally commiting their docker-compose file which contains all their secrets!

This will pull all of the env vars from the .env file in the project root dir

See this chat for context.

Additional Details

Before merging we should:

• Update the contributing wiki with these changes
• Announce this change, so users can extract their secrets from the docker-compose file and put them into a .env file before pulling

Did you:

• Join the Python Discord Community?
• If dependencies have been added or updated, run pipenv lock?
• Lint your code (pipenv run lint)?
• Set the PR to allow edits from contributors?

[ChrisLovering]

Some alternatives to this approach would be:

• Explicitly list all env vars in the enviroment section of docker-compose.yml so that they get pulled into the container from .env
• Tell users to put their .env file inside ./bot/ (So it gets copied to the container) and use dotenv in contants.py to load from there

[MarkKoz]

If this doesn't already have a default value set in Python then it should. Alternatively, the default can remain in the compose file but I prefer defining it in Python.

[ChrisLovering]

The default is currently set to redis.default.svc.cluster.local

sir-lancebot/bot/constants.py

Line 278 in c6353a8

host = environ.get("REDIS_HOST", "redis.default.svc.cluster.local")

[MarkKoz]

Okay, that's the production host and it should stay that way. Therefore, it's best to leave it set to redis within the compose file since it can spin up a redis container. If running without Docker Compose, I presume users are already told they have to manually enable fakeredis?

[ChrisLovering]

I've added the default back in.
They are, but it's a little buried in the lancebot wiki atm https://pythondiscord.com/pages/contributing/sir-lancebot/sir-lancebot-env-var-reference/
I'm planning on drafting a guide to be added onto the wiki for the docker setup (As it's not currently documented).

[HassanAbouelela]

LGTM, thanks for updating this.