Connect Four Game by Shivansh-007 · Pull Request #560 · python-discord/sir-lancebot

Shivansh-007 · 2021-01-19T01:08:49Z

Relevant Issues

Continued #365 as the original contributor ditched it.
And closes #244

Description

Implemented all the changes which were requested in the pr, and changed the bot message to a embed rather than content.

Dynamic Board size
Checks for user already playing/in waiting room.

Screenshots

Additional Details

When playing against a CPU there's

a 1 in 10 chance they will NOT place the counter in the correct spot to win when possible
a 1 in 4 chance they will NOT block the player from winning where possible

Did you:

Join the Python Discord Community?
If dependencies have been added or updated, run pipenv lock?
Lint your code (pipenv run lint)?
Set the PR to allow edits from contributors?

HassanAbouelela

Well done so far! You are well on your way to making your first contibution. One request: can you add a way to stop a game early? Right now you either have to wait out the 30 second timeout or finish the game.

…dant code, and DRY

…title

HassanAbouelela

Bumping some still open comments, and a bug. I'll leave a more complete review after they've been addressed.

…game over (winner/loser) code ; add case_insensitive alias

Shivansh-007 · 2021-01-24T11:31:19Z

@HassanAbouelela Mentioned all requested changes!
(and fixed another bug - there was no message when the user Drew)

… discord.member object

…7/sir-lancebot into feature/connect_four

…ce some emojis are made of len() > 1

…7/sir-lancebot into feature/connect_four

# Conflicts: # Pipfile.lock

…rivate Message error

Shivansh-007 · 2021-02-24T12:05:44Z

@ChrisLovering Mentioned requested changes :D.

ChrisLovering

Looks good to me, tested locally too 👍

Co-authored-by: Hassan Abouelela <47495861+HassanAbouelela@users.noreply.github.com>

Add connect four cog supporting player vs player and player vs ai

3616302

HassanAbouelela mentioned this pull request Jan 19, 2021

Connect Four Game #365

Closed

4 tasks

HassanAbouelela added season: evergreen status: needs review Author is waiting for someone to review and approve type: feature Relating to the functionality of the application. labels Jan 19, 2021

HassanAbouelela suggested changes Jan 19, 2021

View reviewed changes

HassanAbouelela added status: WIP Work In Progress and removed status: needs review Author is waiting for someone to review and approve labels Jan 19, 2021

Shivansh-007 added 9 commits January 20, 2021 05:28

fix grammar and spacing

f44a39d

COrrect annotations and improve docstrings ; make code more pythonic

24e7f95

Change Ai to bot's user and add stop game functionality, remove redun…

d1acfa3

…dant code, and DRY

Add loading message before finishing all reactions and improve embed …

46e594c

…title

Improve embeds and docstrings

089baf1

Add ability to get custom tokens from the bot

a972cd1

Remove redundant code

8175bc0

Check if the emoji given by user is available

35b2984

Fix user given emoji check

db53775

Shivansh-007 requested a review from HassanAbouelela January 23, 2021 12:15

HassanAbouelela suggested changes Jan 24, 2021

View reviewed changes

Comment thread bot/exts/evergreen/connect_four.py Outdated

Comment thread bot/exts/evergreen/connect_four.py Outdated

Comment thread bot/exts/evergreen/connect_four.py

Comment thread bot/exts/evergreen/connect_four.py

Comment thread bot/exts/evergreen/connect_four.py

Send a message on draw (was catching a error earlier) ; Improve send …

f701e93

…game over (winner/loser) code ; add case_insensitive alias

Fix lint issues

914f2a8

Xithrius added area: backend Related to internal functionality and utilities level: 1 - intermediate labels Jan 24, 2021

Merge branch 'master' into feature/connect_four

12f283f

Shivansh-007 requested a review from HassanAbouelela January 24, 2021 21:30

HassanAbouelela suggested changes Jan 28, 2021

View reviewed changes

Shivansh-007 added 2 commits January 30, 2021 17:21

Fix misleading game_over docstring

a563d3a

Line 114, 115 was cuasing error as a set was being sent to it instead…

79fb946

… discord.member object

Shivansh-007 added 3 commits January 31, 2021 04:55

Let game_over function handle all gane over instances

46ca17d

Add ability to choose ai token while playing against ai

2596862

Merge branch 'feature/connect_four' of https://github.com/Shivansh-00…

2ab49ec

…7/sir-lancebot into feature/connect_four

Shivansh-007 requested a review from HassanAbouelela January 30, 2021 23:39

HassanAbouelela suggested changes Feb 1, 2021

View reviewed changes

Comment thread bot/exts/evergreen/connect_four.py Outdated

Remove the use of globals and instead use class variables

29c84ad

Shivansh-007 requested a review from HassanAbouelela February 1, 2021 08:07

Shivansh-007 and others added 2 commits February 1, 2021 14:46

Add check if game is not intialized

4b8f578

Merge branch 'master' into feature/connect_four

72d5c9d

HassanAbouelela approved these changes Feb 1, 2021

View reviewed changes

Xithrius mentioned this pull request Feb 7, 2021

Connect Four Game #559

Closed

4 tasks

Shivansh-007 added 2 commits February 8, 2021 06:59

Use emojis library to do the check instead of checking len() == 1 sin…

8321add

…ce some emojis are made of len() > 1

Merge branch 'feature/connect_four' of https://github.com/Shivansh-00…

48f483e

…7/sir-lancebot into feature/connect_four

Shivansh-007 requested a review from Akarys42 as a code owner February 8, 2021 01:30

Shivansh-007 requested a review from HassanAbouelela February 8, 2021 01:31

HassanAbouelela approved these changes Feb 19, 2021

View reviewed changes

ChrisLovering reviewed Feb 22, 2021

View reviewed changes

Shivansh-007 added 2 commits February 23, 2021 16:20

Merge remote-tracking branch 'origin/master' into feature/connect_four

e426aeb

# Conflicts: # Pipfile.lock

Fix pipfile conflicts, and add/use emojis from constants.py

13dad6b

ChrisLovering requested changes Feb 23, 2021

View reviewed changes

Comment thread bot/exts/evergreen/connect_four.py

Shivansh-007 added 3 commits February 24, 2021 17:28

Make connect 4 and its sub command ai guild only

b70a3fb

Mentioned community bot commands channel while sending embed for No P…

fadb1c4

…rivate Message error

Make Flake8 happy (reorder imports)

598cb12

Shivansh-007 requested a review from ChrisLovering February 24, 2021 12:05

ChrisLovering approved these changes Feb 24, 2021

View reviewed changes

HassanAbouelela reviewed Feb 24, 2021

View reviewed changes

Comment thread bot/exts/evergreen/error_handler.py

Correct the parentheses format

550e0e8

Co-authored-by: Hassan Abouelela <47495861+HassanAbouelela@users.noreply.github.com>

HassanAbouelela merged commit 09c79fa into python-discord:master Feb 24, 2021

Shivansh-007 deleted the feature/connect_four branch February 24, 2021 15:25

Uh oh!

Conversation

Shivansh-007 commented Jan 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Relevant Issues

Description

Screenshots

Additional Details

Did you:

Uh oh!

HassanAbouelela left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HassanAbouelela left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Shivansh-007 commented Jan 24, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Shivansh-007 commented Feb 24, 2021

Uh oh!

ChrisLovering left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Shivansh-007 commented Jan 19, 2021 •

edited

Loading