Add .pyfacts command by MrKomodoDragon · Pull Request #596 · python-discord/sir-lancebot

MrKomodoDragon · 2021-02-16T17:59:19Z

Relevant Issues

Closes #587

Description

I added a text fie with some facts and made the command send an embed with the fact.

Reasoning

The text file would be simplest to edit and change.

Screenshots

Did you:

Join the Python Discord Community?
If dependencies have been added or updated, run pipenv lock?
Lint your code (pipenv run lint)?
Set the PR to allow edits from contributors?

Co-authored-by: ChrisJL <ChrisLovering@users.noreply.github.com>

ChrisLovering

Looks good to me, tested locally too.

We should definitely add more facts to this list!

MrKomodoDragon · 2021-02-16T18:55:18Z

Any suggestions!

ChrisLovering · 2021-02-16T19:12:31Z

https://github.com/satwikkansal/wtfpython Has some interesting facts/behaviour of python.

Co-authored-by: Shivansh-007 <69356296+Shivansh-007@users.noreply.github.com>

…Monty Python for Fact 1

Shivansh-007 · 2021-02-17T02:38:19Z

+with open('bot/resources/evergreen/python_facts.txt') as file:
+    FACTS = list(file)
+
+COLORS = [0x4B8BBE, 0xFFD43B, ]


Get the COLORS from constants.py or add this there.

Shivansh-007 · 2021-02-22T15:27:35Z

One more thing, please update the screenshot you have put while opening the Pull Request.

Shivansh-007 · 2021-02-22T23:49:27Z

+    FACT_CYCLE = itertools.cycle(FACTS)
+
+COLORS = [Colours.python_blue, Colours.python_yellow]
+COLOR_CYCLE = itertools.cycle(COLORS)


Since COLORS is not being used anywhere, directly put it in the cycle, same for the facts.

COLOR_CYCLE = itertools.cycle([Colours.python_blue, Colours.python_yellow])

Shivansh-007

Thanks! Looks Good To Me!

MrKomodoDragon · 2021-02-23T17:19:07Z

Just an idea, maybe make a google form for suggesting facts like for .topic?

ks129 · 2021-02-23T17:22:48Z

@MrKomodoDragon If we take suggestions, we should use GitHub Discussions instead.

ChrisLovering · 2021-02-23T17:25:22Z

If we are going to be taking suggestions, should we add a footer to the embed with a link to the github discussion, like we do for .topics?

MrKomodoDragon · 2021-02-23T17:59:54Z

Good idea chris!

MrKomodoDragon · 2021-02-23T19:25:25Z

So, link to the discussion?

RohanJnr · 2021-02-24T18:51:04Z

I would like an additional command which would append a python fact to the file and refresh the variable in the Cog which is storing the data loaded from the file.
This command would be only accessible to mods+.
What are your thoughts on this?

RohanJnr · 2021-02-24T18:54:11Z

How about a background function which would send a python fact in the #python-general channel everyday ? (this would be cool if we have many facts tho)

MrKomodoDragon · 2021-02-24T18:54:30Z

Nice Idea!

MrKomodoDragon · 2021-02-24T18:54:49Z

How would I add it though? 🤔

MrKomodoDragon · 2021-02-24T18:55:32Z

I don't like the idea of sending a random fact daily, i prefer it is used periodically when people feel like it.

Kronifer

This looks great, just one critique so far!

Kronifer · 2021-03-04T20:09:30Z

+        embed = discord.Embed(title='Python Facts',
+                                    description=next(FACTS),
+                                    colour=next(COLORS))
+        embed.add_field(name='Suggestions',


replace the above embed code with:

embed.add_field( name='Suggestions', value="Suggest more facts [here!](https://github.com/python-discord/meta/discussions/93)" )

Hmmm... why do you want to take out “Want to suggest a fact?” 🤔

Ok, i understand, a little wordy

for consistency with .topic

Kronifer

Looks amazing!

Add .pyfacts command

7ba7149

ChrisLovering requested changes Feb 16, 2021

View reviewed changes

Comment thread bot/exts/evergreen/pythonfacts.py Outdated

Comment thread bot/exts/evergreen/pythonfacts.py Outdated

MrKomodoDragon and others added 4 commits February 16, 2021 10:39

Change bot: Bot to commands.Bot for consistency

b112226

Co-authored-by: ChrisJL <ChrisLovering@users.noreply.github.com>

Remove unused import

fdfa5c7

Merge branch 'master' of https://github.com/MrKomodoDragon/sir-lancebot

e571087

Move loading of file outside of command

06d600f

ChrisLovering approved these changes Feb 16, 2021

View reviewed changes

Shivansh-007 suggested changes Feb 17, 2021

View reviewed changes

MrKomodoDragon and others added 4 commits February 16, 2021 17:57

Remove bold

57aec01

Co-authored-by: Shivansh-007 <69356296+Shivansh-007@users.noreply.github.com>

Update docstring for Cog

a68e8f5

Co-authored-by: Shivansh-007 <69356296+Shivansh-007@users.noreply.github.com>

Change Docstring for command

6aae339

Co-authored-by: Shivansh-007 <69356296+Shivansh-007@users.noreply.github.com>

Add colors and move embed out of send statement; add more info about …

5164ba4

…Monty Python for Fact 1

Shivansh-007 reviewed Feb 17, 2021

View reviewed changes

Comment thread bot/exts/evergreen/pythonfacts.py Outdated

Shivansh-007 reviewed Feb 17, 2021

View reviewed changes

Xithrius added area: backend Related to internal functionality and utilities priority: 2 - normal status: waiting for author Waiting for author to address a review or respond to a comment type: feature Relating to the functionality of the application. labels Feb 21, 2021

Switch to itertools.cycle and add colors to constants.py

16476ab

Shivansh-007 reviewed Feb 22, 2021

View reviewed changes

Remove unused variables

aef25cb

Shivansh-007 approved these changes Feb 23, 2021

View reviewed changes

MrKomodoDragon mentioned this pull request Feb 25, 2021

Add Subsection Command for WTFPython #602

Closed

Xithrius removed the priority: 2 - normal label Feb 28, 2021

Add link to discussion for suggesting facts in Embed

55e3378

Kronifer suggested changes Mar 4, 2021

View reviewed changes

Remove "Want to suggest a fact?" for consistency

1669b50

Kronifer approved these changes Mar 4, 2021

View reviewed changes

MrKomodoDragon added 2 commits March 4, 2021 14:35

Merge branch 'master' into master

431465c

Remove arrows (whoopsies)!

bd49374

HassanAbouelela approved these changes Mar 4, 2021

View reviewed changes

HassanAbouelela merged commit caacd7b into python-discord:master Mar 4, 2021

Uh oh!

Conversation

MrKomodoDragon commented Feb 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Relevant Issues

Description

Reasoning

Screenshots

Did you:

Uh oh!

Uh oh!

Uh oh!

ChrisLovering left a comment

Choose a reason for hiding this comment

Uh oh!

MrKomodoDragon commented Feb 16, 2021

Uh oh!

ChrisLovering commented Feb 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Shivansh-007 Feb 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MrKomodoDragon Feb 22, 2021

Choose a reason for hiding this comment

Uh oh!

Shivansh-007 commented Feb 22, 2021

Uh oh!

Shivansh-007 Feb 22, 2021

Choose a reason for hiding this comment

Uh oh!

MrKomodoDragon Feb 22, 2021

Choose a reason for hiding this comment

Uh oh!

Shivansh-007 Feb 22, 2021

Choose a reason for hiding this comment

Uh oh!

Shivansh-007 left a comment

Choose a reason for hiding this comment

Uh oh!

MrKomodoDragon commented Feb 23, 2021

Uh oh!

ks129 commented Feb 23, 2021

Uh oh!

ChrisLovering commented Feb 23, 2021

Uh oh!

MrKomodoDragon commented Feb 23, 2021

Uh oh!

MrKomodoDragon commented Feb 23, 2021

Uh oh!

RohanJnr commented Feb 24, 2021

Uh oh!

RohanJnr commented Feb 24, 2021

Uh oh!

MrKomodoDragon commented Feb 24, 2021

Uh oh!

MrKomodoDragon commented Feb 24, 2021

Uh oh!

MrKomodoDragon commented Feb 24, 2021

Uh oh!

Kronifer left a comment

Choose a reason for hiding this comment

Uh oh!

Kronifer Mar 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MrKomodoDragon Mar 4, 2021

Choose a reason for hiding this comment

Uh oh!

MrKomodoDragon Mar 4, 2021

Choose a reason for hiding this comment

MrKomodoDragon commented Feb 16, 2021 •

edited

Loading

ChrisLovering commented Feb 16, 2021 •

edited

Loading

Shivansh-007 Feb 17, 2021 •

edited

Loading

Kronifer Mar 4, 2021 •

edited

Loading