Improve Wikipedia Command#600
Merged
Senjan21 merged 6 commits intoMar 1, 2021
Merged
Conversation
…use pagination instead of asking user for input
Xithrius
added
area: frontend
RohanJnr
suggested changes
Feb 24, 2021
Contributor
RohanJnr
left a comment
RohanJnr
left a comment
There was a problem hiding this comment.
Just picked up some stuff just by glancing through the code, haven't tested a lot yet, will do that soon
RohanJnr
reviewed
Feb 24, 2021
RohanJnr
added
status: waiting for author
… '\' for long variable values, pass in ctx.channel instead of the full ctx
RohanJnr
approved these changes
Feb 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant Issues
Closes #565
Description
This has been implemented with help of
aiohttpto request and get json data of the Wikipedia Article. It then filters the data and stores only the required information namelyTitle,SnippetandPage ID. This filtered data to the Line Paginator.Reasoning
Approved by Staff Member.
Screenshots
No Result Found
Results Found
1 Result Found
Did you:
pipenv run lint)?