Add WTF Python Command by Shivansh-007 · Pull Request #605 · python-discord/sir-lancebot

Shivansh-007 · 2021-03-02T09:58:29Z

Relevant Issues

Closes #602

Description

Gets the fuzzy match of a search query, returns None if the ratio is below 90 else returns the fuzzy match. If the return is None, then we send our custom Error Message else it sends the link to the subsection of the WTF Python README.md.

Reasoning

Approved by a staff.

Screenshots

On Dark Theme

On Light Theme

(I went blind while teking it, and am helf blind rihgt now, so ignre ayn spellign misteke)

Did you:

Join the Python Discord Community?
Lint your code (pipenv run lint)?
Set the PR to allow edits from contributors?

…of a wrapper

ChrisLovering

Code looks good, just one issue while testing locally. I think it could be a good idea to have a .wtf list or similar, to output all of the available pages. Maybe one for after the paginator PR in merged.

Shivansh-007 · 2021-03-06T12:48:02Z

Code looks good, just one issue while testing locally. I think it could be a good idea to have a .wtf list or similar, to output all of the available pages. Maybe one for after the paginator PR in merged.

Alright will do.

ToxicKidz

LGTM!

…se try to load the extension.

anand2312

LGTM 👍🏻

laundmo · 2021-04-29T11:34:24Z

+
+
+class WTFPython(commands.Cog):
+    """Cog that allows users to retrieve issues from GitHub."""


This docstring seems to be a leftover from copying the cog

Suggested change

"""Cog that allows users to retrieve issues from GitHub."""

"""Cog that allows geting WTF Python entries from the WTF Python repository."""

laundmo · 2021-04-29T11:36:23Z

+                )
+
+    def fuzzy_match_header(self, query: str) -> Optional[str]:
+        """Returns the fuzzy match of a query if its ratio is above 90 else returns None."""


Docstring mentions a ratio of 90, though the ratio is a global variable and currently 75

Suggested change

"""Returns the fuzzy match of a query if its ratio is above 90 else returns None."""

"""Returns the fuzzy match of a query if its ratio is above `MINIMUM_CERTAINTY` else returns None."""

Kronifer

Few nitpicks, but looks good!

Kronifer · 2021-05-14T19:24:09Z

+    @commands.command(aliases=("wtf",))
+    async def wtf_python(self, ctx: commands.Context, *, query: str) -> None:
+        """
+        Search wtf python.


wtf is capitalised in other areas

Shivansh-007 · 2021-08-07T10:04:47Z

I don't think I am having enough time to look into this and it has been stale for quite a while now, so whoever wants can take over the PR, and deliver the feature!

Xithrius

@decorator-factory has noticed that this PR still uses fuzzywuzzy, which contains the GPLv2 license. We now use rapidfuzz because it uses the MIT license, so this new feature needs to reflect this change.

brad90four · 2021-09-03T13:04:03Z

I think I can take this one, looks like rapidfuzz also has an extractOne method and the change from fuzzy_wuzzy to rapidfuzz is just the import statement.

Xithrius · 2021-09-03T16:32:46Z

@brad90four I shall assign you. rapidfuzz is currently what we're going with for the default replacement of fuzzy_wuzzy. Be sure to update the dependencies in poetry.lock.

Xithrius · 2021-09-05T20:32:53Z

Given that the restructure of this bot occurred, the main file of bot/exts/evergreen/wtf_python.py will need to be moved to bot/exts/utilities/wtf_python.py.

brad90four · 2021-09-07T10:57:01Z

Should I get perms to Shivansh's repo in order to push changes to the feature branch or should I make a new PR with a branch from my own repo?

Xithrius · 2021-09-07T10:58:55Z

Make a new PR you will.

Add WTF Python Command

d3c9780

ChrisLovering requested changes Mar 4, 2021

View reviewed changes

Shivansh-007 added 2 commits March 5, 2021 07:38

Fix grammar in docstrings, remove redundant variable, remove the use …

56ea9e2

…of a wrapper

Fix indentation issues and make use of triple quotes

d23cc4d

Shivansh-007 requested a review from ChrisLovering March 5, 2021 02:14

ChrisLovering reviewed Mar 5, 2021

View reviewed changes

Comment thread bot/exts/evergreen/wtf_python.py Outdated

Update docstrings and remove redundant list()

4dcc2fe

Shivansh-007 requested a review from ChrisLovering March 6, 2021 02:01

ChrisLovering requested changes Mar 6, 2021

View reviewed changes

Comment thread bot/exts/evergreen/wtf_python.py

Xithrius added area: backend Related to internal functionality and utilities season: evergreen status: needs review Author is waiting for someone to review and approve type: feature Relating to the functionality of the application. labels Mar 6, 2021

Change minimum certainty to 75.

415b7a4

ToxicKidz suggested changes Mar 12, 2021

View reviewed changes

Comment thread bot/exts/evergreen/wtf_python.py Outdated

Shivansh-007 requested a review from ChrisLovering March 12, 2021 23:14

Make 'make_embed' function a non async function

3b8eadd

ToxicKidz approved these changes Mar 12, 2021

View reviewed changes

RohanJnr reviewed Mar 13, 2021

View reviewed changes

Comment thread bot/exts/evergreen/wtf_python.py Outdated

Comment thread bot/exts/evergreen/wtf_python.py Outdated

Base automatically changed from master to main March 13, 2021 20:09

Shivansh-007 added 2 commits March 14, 2021 18:06

Try to unload WTFPython Extension if max fetch requests hit i.e. 3 el…

6465862

…se try to load the extension.

Correct log messages.

a2cdfe9

Shivansh-007 marked this pull request as draft March 14, 2021 13:02

Make flake8 happy :D

3ae3aad

anand2312 suggested changes Mar 14, 2021

View reviewed changes

Comment thread bot/exts/evergreen/wtf_python.py Outdated

anand2312 reviewed Mar 14, 2021

View reviewed changes

Comment thread bot/exts/evergreen/wtf_python.py Outdated

anand2312 reviewed Mar 14, 2021

View reviewed changes

Comment thread bot/exts/evergreen/wtf_python.py Outdated

anand2312 reviewed Mar 14, 2021

View reviewed changes

Comment thread bot/exts/evergreen/wtf_python.py Outdated

anand2312 reviewed Mar 14, 2021

View reviewed changes

Comment thread bot/exts/evergreen/wtf_python.py Outdated

Shivansh-007 requested review from RohanJnr and Xithrius March 15, 2021 02:01

anand2312 approved these changes Mar 15, 2021

View reviewed changes

ToxicKidz suggested changes Apr 7, 2021

View reviewed changes

Comment thread bot/exts/evergreen/wtf_python.py Outdated

Comment thread bot/exts/evergreen/wtf_python.py

Fix typo in WTF_PYTHON_RAW_URL

f82169f

laundmo suggested changes Apr 29, 2021

View reviewed changes

Shivansh-007 marked this pull request as draft May 11, 2021 05:07

Kronifer suggested changes May 14, 2021

View reviewed changes

ToxicKidz added status: waiting for author Waiting for author to address a review or respond to a comment and removed status: needs review Author is waiting for someone to review and approve labels May 17, 2021

Xithrius added up for grabs Available for anyone to work on and removed status: waiting for author Waiting for author to address a review or respond to a comment labels Aug 13, 2021

Xithrius removed their request for review August 16, 2021 02:28

Xithrius requested changes Aug 16, 2021

View reviewed changes

Xithrius assigned brad90four Sep 3, 2021

Xithrius added status: WIP Work In Progress and removed up for grabs Available for anyone to work on labels Sep 3, 2021

Xithrius added category: utilities Related to utilities category: fun Related to fun and games and removed category: evergreen category: fun Related to fun and games labels Sep 6, 2021

brad90four mentioned this pull request Sep 7, 2021

Add WTF Python Command #859

Merged

4 tasks

Xithrius closed this Sep 7, 2021

Shivansh-007 deleted the feature/wtf-python branch September 7, 2021 23:34



		class WTFPython(commands.Cog):
		"""Cog that allows users to retrieve issues from GitHub."""

	"""Cog that allows users to retrieve issues from GitHub."""
	"""Cog that allows geting WTF Python entries from the WTF Python repository."""

	"""Returns the fuzzy match of a query if its ratio is above 90 else returns None."""
	"""Returns the fuzzy match of a query if its ratio is above `MINIMUM_CERTAINTY` else returns None."""

Uh oh!

Conversation

Shivansh-007 commented Mar 2, 2021

Relevant Issues

Description

Reasoning

Screenshots

Did you:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ChrisLovering left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Shivansh-007 commented Mar 6, 2021

Uh oh!

Uh oh!

ToxicKidz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anand2312 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

laundmo Apr 29, 2021

Choose a reason for hiding this comment

Uh oh!

laundmo Apr 29, 2021

Choose a reason for hiding this comment

Uh oh!

Kronifer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Kronifer May 14, 2021

Choose a reason for hiding this comment

Uh oh!

Shivansh-007 commented Aug 7, 2021

Uh oh!

Xithrius left a comment

Choose a reason for hiding this comment

Uh oh!

brad90four commented Sep 3, 2021

Uh oh!

Xithrius commented Sep 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Xithrius commented Sep 5, 2021

Uh oh!

brad90four commented Sep 7, 2021

Uh oh!

Xithrius commented Sep 7, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Xithrius commented Sep 3, 2021 •

edited

Loading